Index: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp =================================================================== --- llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp +++ llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp @@ -3981,7 +3981,8 @@ EVT ShValTy = N0.getValueType(); // Fold bit comparisons when we can. - if ((Cond == ISD::SETEQ || Cond == ISD::SETNE) && + if (getBooleanContents(N0.getValueType()) == ZeroOrOneBooleanContent && + (Cond == ISD::SETEQ || Cond == ISD::SETNE) && (VT == ShValTy || (isTypeLegal(VT) && VT.bitsLE(ShValTy))) && N0.getOpcode() == ISD::AND) { if (auto *AndRHS = dyn_cast(N0.getOperand(1))) { Index: llvm/test/CodeGen/NVPTX/pow2_mask_cmp.ll =================================================================== --- llvm/test/CodeGen/NVPTX/pow2_mask_cmp.ll +++ llvm/test/CodeGen/NVPTX/pow2_mask_cmp.ll @@ -2,9 +2,15 @@ ; Tests the following pattern: ; (X & 8) != 0 --> (X & 8) >> 3 +; +; This produces incorrect code when boolean false is represented +; as a negative one, and this test checks that the transform is +; not triggered. ; CHECK-LABEL: @pow2_mask_cmp -; CHECK: bfe.u32 {{%r[0-9]+}}, {{%r[0-9]+}}, 3, 1 +; CHECK: and.b32 [[AND:%r[0-9]+]], %r{{[0-9]+}}, 8 +; CHECK: setp.ne.s32 [[SETP:%p[0-9+]]], [[AND]], 0 +; CHECK: selp.u32 %r{{[0-9]+}}, 1, 0, [[SETP]] define i32 @pow2_mask_cmp(i32 %x) { %a = and i32 %x, 8 %cmp = icmp ne i32 %a, 0