This is an archive of the discontinued LLVM Phabricator instance.

Differential D89225

[MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled
ClosedPublic

Authored by mati865 on Oct 12 2020, 2:57 AM.

Details

Reviewers
mstorsjo
ASDenysPetrov
Commits
rG3b1d018c0dba: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled
Summary

Otherwise it's easy to hit 2^16 DLL exports limit.

Diff Detail

Event Timeline

mati865 created this revision.Oct 12 2020, 2:57 AM
Herald added subscribers: cfe-commits, mgorny. · View Herald TranscriptOct 12 2020, 2:57 AM
mati865 requested review of this revision.Oct 12 2020, 2:57 AM
mati865 mentioned this in D87547: [MinGW][clang-shlib] Build by default on MinGW.
Harbormaster completed remote builds in B74765: Diff 297526.Oct 12 2020, 3:32 AM
mstorsjo added a reviewer: ASDenysPetrov.Oct 12 2020, 4:18 AM

+1, looks sensible to me - I can give it the formal approval a bit later, but leaving it open for a bit for others to comment on first.

ASDenysPetrov accepted this revision.Oct 12 2020, 4:33 AM

It works for me. Well done!

I've applied your patch and tried this:

cmake -GNinja ../llvm -DLLVM_LIT_ARGS=-sv -DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_ENABLE_PROJECTS=clang -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../../install -DLLVM_ENABLE_ASSERTIONS=ON
ninja
This revision is now accepted and ready to land.Oct 12 2020, 4:33 AM
This revision was landed with ongoing or failed builds.Oct 12 2020, 1:28 PM
Closed by commit rG3b1d018c0dba: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled (authored by mati865, committed by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG3b1d018c0dba: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled.
mstorsjo mentioned this in D73156: [clang] Build clang-shlib on mingw.Nov 23 2020, 9:15 PM

Revision Contents

PathSize
clang/
tools/
4 lines

Diff 297684

clang/tools/CMakeLists.txt

Show All 9 Lines
add_clang_subdirectory(clang-offload-bundler) add_clang_subdirectory(clang-offload-bundler)
add_clang_subdirectory(clang-offload-wrapper) add_clang_subdirectory(clang-offload-wrapper)
add_clang_subdirectory(clang-scan-deps) add_clang_subdirectory(clang-scan-deps)
add_clang_subdirectory(c-index-test) add_clang_subdirectory(c-index-test)
add_clang_subdirectory(clang-rename) add_clang_subdirectory(clang-rename)
add_clang_subdirectory(clang-refactor) add_clang_subdirectory(clang-refactor)
if(UNIX OR MINGW) # For MinGW we only enable shared library if LLVM_LINK_LLVM_DYLIB=ON.
# Without that option resulting library is too close to 2^16 DLL exports limit.
if(UNIX OR (MINGW AND LLVM_LINK_LLVM_DYLIB))
add_clang_subdirectory(clang-shlib) add_clang_subdirectory(clang-shlib)
endif() endif()
if(CLANG_ENABLE_ARCMT) if(CLANG_ENABLE_ARCMT)
add_clang_subdirectory(arcmt-test) add_clang_subdirectory(arcmt-test)
add_clang_subdirectory(c-arcmt-test) add_clang_subdirectory(c-arcmt-test)
endif() endif()
Show All 16 Lines