[FE][AIX] Emit error for oversized long long bitfield under 32bit mode

[sfertile]

Thanks for splitting this out XiangLing.

clang/lib/Sema/SemaDecl.cpp

16452

Comment explaining why we need to emit the extra error in this case for AIX.

16454

I would rearrange the order of the conditions so that we first check if we are on AIX for the short-circuiting.

16456

Maybe Value.ugt(32) instead of (unsigned)Value.getZExtValue() > 32

clang/test/Layout/aix-oversized-bitfield.cpp

1

I believe this is running the test twice as C++/

[Xiangling_L]

As we discussed offline, the strategy to handle long long type bitfield under 32bit mode would be the bitcontainer shall be 32-bits unless if a single long long bitfield has length greater than 32 bits (what would have been a diagnostic in xlc/xlclang/xlclang++), then the bitcontainer shall be 64-bits.

clang/lib/Sema/SemaDecl.cpp

if (!FieldTy->isDependentType()) {
 
     // Over-wide bitfields are an error in C or when using the MSVC bitfield
     // ABI.
     bool CStdConstraintViolation =
         BitfieldIsOverwide && !getLangOpts().CPlusPlus;
     bool MSBitfieldViolation =
         Value.ugt(TypeStorageSize) &&
         (IsMsStruct || Context.getTargetInfo().getCXXABI().isMicrosoft());
-    if (CStdConstraintViolation || MSBitfieldViolation) {
+
+    bool AIXBitfieldViolation = false;
+    if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs<BuiltinType>()) {
+      if ((BTy->getKind() == BuiltinType::ULongLong ||
+           BTy->getKind() == BuiltinType::LongLong) &&
+          (unsigned)Value.getZExtValue() > 32 &&
+          Context.getTargetInfo().getTriple().isArch32Bit() &&
+          Context.getTargetInfo().getTriple().getOS() == llvm::Triple::AIX) {
+        AIXBitfieldViolation = true;
+        TypeStorageSize = 32;
+        TypeWidth = 32;
+      }
+    }
+
+    if (CStdConstraintViolation || MSBitfieldViolation ||
+        AIXBitfieldViolation) {
       unsigned DiagWidth =
           CStdConstraintViolation ? TypeWidth : TypeStorageSize;
       if (FieldName)
         return Diag(FieldLoc, diag::err_bitfield_width_exceeds_type_width)
                << FieldName << (unsigned)Value.getZExtValue()
                << !CStdConstraintViolation << DiagWidth;
 
       return Diag(FieldLoc, diag::err_anon_bitfield_width_exceeds_type_width)

clang/test/Layout/aix-oversized-bitfield.cpp

+// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -fsyntax-only -verify -x c++ %s
+
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -fdump-record-layouts \
+// RUN:     -fsyntax-only %s | \
+// RUN:   FileCheck --check-prefix=CHECK64 %s
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -fdump-record-layouts \
+// RUN:     -fsyntax-only -x c++ %s | \
+// RUN:   FileCheck --check-prefix=CHECK64 %s
+
+struct A {
+  long long l : 64; // expected-error{{width of bit-field 'l' (64 bits) exceeds size of its type (32 bits)}}
+};
+
+int a = sizeof(A);
+
+// CHECK64:      *** Dumping AST Record Layout
+// CHECK64-NEXT:          0 | struct A
+// CHECK64-NEXT:     0:0-63 |   long long l
+// CHECK64-NEXT:            | [sizeof=8, dsize=8, align=8, preferredalign=8,
+// CHECK64-NEXT:            |  nvsize=8, nvalign=8, preferrednvalign=8]