This is an archive of the discontinued LLVM Phabricator instance.

Differential D89022

Remove unused variables
ClosedPublic

Authored by GMNGeoffrey on Oct 7 2020, 6:25 PM.

Details

Reviewers
anna
saugustine
Commits
rG93db4a8ce626: Remove unused variables
Summary

These are unused since
https://reviews.llvm.org/rG35cb45c533fb76dcfc9f44b4e8bbd5d8a855ed2a
causing -Wunused warnings.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Oct 7 2020, 6:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 6:25 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
GMNGeoffrey requested review of this revision.Oct 7 2020, 6:25 PM
saugustine accepted this revision.Oct 7 2020, 6:30 PM
This revision is now accepted and ready to land.Oct 7 2020, 6:30 PM
This revision was landed with ongoing or failed builds.Oct 7 2020, 6:30 PM
Closed by commit rG93db4a8ce626: Remove unused variables (authored by GMNGeoffrey). · Explain Why
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rG93db4a8ce626: Remove unused variables.
GMNGeoffrey mentioned this in D87148: [ImplicitNullCheck] Handle Nonzero faulting pages and complex addressing.Oct 7 2020, 6:31 PM

Committed as https://github.com/llvm/llvm-project/commit/93db4a8ce6261dc36e233f5e0b60cfbb3ea1bd8f

Harbormaster completed remote builds in B74380: Diff 296845.Oct 7 2020, 6:47 PM

Revision Contents

PathSize
llvm/
lib/
CodeGen/
4 lines

Diff 296846

llvm/lib/CodeGen/ImplicitNullChecks.cpp

Show First 20 Lines • Show All 363 Lines • ▼ Show 20 LinesImplicitNullChecks::areMemoryOpsAliased(const MachineInstr &MI,
} }
return AR_NoAlias; return AR_NoAlias;
} }
ImplicitNullChecks::SuitabilityResult ImplicitNullChecks::SuitabilityResult
ImplicitNullChecks::isSuitableMemoryOp(const MachineInstr &MI, ImplicitNullChecks::isSuitableMemoryOp(const MachineInstr &MI,
unsigned PointerReg, unsigned PointerReg,
ArrayRef<MachineInstr *> PrevInsts) { ArrayRef<MachineInstr *> PrevInsts) {
int64_t Offset;
bool OffsetIsScalable;
const MachineOperand *BaseOp;
// Implementation restriction for faulting_op insertion // Implementation restriction for faulting_op insertion
// TODO: This could be relaxed if we find a test case which warrants it. // TODO: This could be relaxed if we find a test case which warrants it.
if (MI.getDesc().getNumDefs() > 1) if (MI.getDesc().getNumDefs() > 1)
return SR_Unsuitable; return SR_Unsuitable;
if (!MI.mayLoadOrStore() || MI.isPredicable()) if (!MI.mayLoadOrStore() || MI.isPredicable())
return SR_Unsuitable; return SR_Unsuitable;
auto AM = TII->getAddrModeFromMemoryOp(MI, TRI); auto AM = TII->getAddrModeFromMemoryOp(MI, TRI);
▲ Show 20 Lines • Show All 446 Lines • Show Last 20 Lines