This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Linalg] Refactor Linalg creation of loops to allow passing iterArgs - NFC
ClosedPublic

Authored by nicolasvasilache on Sep 29 2020, 5:07 AM.

Details

Summary

This revision changes the signatures of helper function that Linalg uses to create loops so that they can also take iterArgs.
iterArgs are asserted empty to ensure no functional change.
This is a mechanical change in preparation of tiling on linalg on tensors to avoid polluting the implementation with an NFC change.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2020, 5:07 AM
nicolasvasilache requested review of this revision.Sep 29 2020, 5:07 AM
ftynse accepted this revision.Sep 29 2020, 5:28 AM
This revision is now accepted and ready to land.Sep 29 2020, 5:28 AM
pifon2a accepted this revision.Sep 29 2020, 6:10 AM

Fix compilation.

This revision was landed with ongoing or failed builds.Sep 29 2020, 6:51 AM
This revision was automatically updated to reflect the committed changes.