Page MenuHomePhabricator

Delete port forwarding if ConnectRemote fails.
ClosedPublic

Authored by ovyalov on Apr 3 2015, 4:12 PM.

Details

Reviewers
tberghammer
Summary

Since there is a possibility that we can call ConnectRemote a few times (for example, lldb-server is taking time to start) adding such precautionary measure to be sure that ConnectRemote doesn't introduce any leftovers.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 23243.Apr 3 2015, 4:12 PM
ovyalov retitled this revision from to Delete port forwarding if ConnectRemote fails..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added a reviewer: tberghammer.
ovyalov added a subscriber: Unknown Object (MLST).
tberghammer accepted this revision.Apr 7 2015, 3:01 AM
tberghammer edited edge metadata.

LGTM.

Thanks for fixing the port forward leak.

This revision is now accepted and ready to land.Apr 7 2015, 3:01 AM
ovyalov closed this revision.Apr 7 2015, 10:27 AM

AFFECTED FILES

/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h

USERS

ovyalov (Author)

http://reviews.llvm.org/rL234332