Page MenuHomePhabricator

Utility: ignore OS version on non-Darwin targets in `ArchSpec`
ClosedPublic

Authored by compnerd on Sep 23 2020, 2:01 PM.

Details

Summary

The OS version field is generally not very helpful for non-Darwin
targets. On Linux, it identifies the kernel version which moves
out-of-sync with the userspace. On Windows, this field actually ends up
corresponding to the Visual Studio toolset version instead of the OS
version. Consider non-Darwin targets without an OS version to be fully
specified.

Diff Detail

Event Timeline

compnerd requested review of this revision.Sep 23 2020, 2:01 PM
compnerd created this revision.
JDevlieghere accepted this revision.Sep 23 2020, 2:03 PM

This is the same change as we did on Github, right? If so this LGTM.

This revision is now accepted and ready to land.Sep 23 2020, 2:03 PM

Correct, this is just upstreaming the original ArchSpec change that we found on Swift.

This revision was landed with ongoing or failed builds.Sep 23 2020, 6:21 PM
This revision was automatically updated to reflect the committed changes.