diff --git a/lld/MachO/Driver.cpp b/lld/MachO/Driver.cpp --- a/lld/MachO/Driver.cpp +++ b/lld/MachO/Driver.cpp @@ -469,7 +469,7 @@ } static void warnIfUnimplementedOption(const opt::Option &opt) { - if (!opt.getGroup().isValid()) + if (!opt.getGroup().isValid() || !opt.hasFlag(DriverFlag::HelpHidden)) return; switch (opt.getGroup().getID()) { case OPT_grp_deprecated: @@ -562,6 +562,8 @@ for (const auto &arg : args) { const auto &opt = arg->getOption(); warnIfDeprecatedOption(opt); + warnIfUnimplementedOption(opt); + // TODO: are any of these better handled via filtered() or getLastArg()? switch (arg->getOption().getID()) { case OPT_INPUT: addFile(arg->getValue()); @@ -593,27 +595,7 @@ case OPT_platform_version: handlePlatformVersion(arg); break; - case OPT_all_load: - case OPT_o: - case OPT_dylib: - case OPT_e: - case OPT_F: - case OPT_L: - case OPT_ObjC: - case OPT_headerpad: - case OPT_headerpad_max_install_names: - case OPT_install_name: - case OPT_rpath: - case OPT_sub_library: - case OPT_Z: - case OPT_arch: - case OPT_syslibroot: - case OPT_sectcreate: - case OPT_dynamic: - // handled elsewhere - break; default: - warnIfUnimplementedOption(opt); break; } } diff --git a/lld/MachO/Options.td b/lld/MachO/Options.td --- a/lld/MachO/Options.td +++ b/lld/MachO/Options.td @@ -101,7 +101,6 @@ def syslibroot : Separate<["-"], "syslibroot">, MetaVarName<"">, HelpText<"Prepend to all library and framework search paths">, - Flags<[HelpHidden]>, Group; def search_paths_first : Flag<["-"], "search_paths_first">, HelpText<"Search for lib.dylib and lib.a at each step in traversing search path (default for Xcode 4 and later)">, @@ -114,7 +113,6 @@ def framework : Separate<["-"], "framework">, MetaVarName<"">, HelpText<"Search for .framework/ on the framework search path">, - Flags<[HelpHidden]>, Group; def weak_framework : Separate<["-"], "weak_framework">, MetaVarName<"">, @@ -134,20 +132,16 @@ def F : JoinedOrSeparate<["-"], "F">, MetaVarName<"">, HelpText<"Add dir to the framework search path">, - Flags<[HelpHidden]>, Group; def all_load : Flag<["-"], "all_load">, HelpText<"Load all members of all static archive libraries">, - Flags<[HelpHidden]>, Group; def ObjC : Flag<["-"], "ObjC">, HelpText<"Load all members of static archives that are an Objective-C class or category.">, - Flags<[HelpHidden]>, Group; def force_load : Separate<["-"], "force_load">, MetaVarName<"">, HelpText<"Load all members static archive library at ">, - Flags<[HelpHidden]>, Group; def grp_content : OptionGroup<"content">, HelpText<"ADDITIONAL CONTENT">; @@ -165,7 +159,6 @@ def filelist : Separate<["-"], "filelist">, MetaVarName<"">, HelpText<"Read names of files to link from ">, - Flags<[HelpHidden]>, Group; def dtrace : Separate<["-"], "dtrace">, MetaVarName<"