Page MenuHomePhabricator

[lldb/test] Clean up version checking.
ClosedPublic

Authored by rupprecht on Sep 21 2020, 3:22 PM.

Details

Summary

A few fixes while trying to figure out why tests are being skipped for arsenm:

  • We check $compiler -v, but -v is --verbose, not --version. Use the long flag name.
  • We check all lines matching version ..., but we should exit early for the first version string we see (which should be the main one). I'm not sure if this is the issue, but perhaps this is causing some users to skip some tests if another "version ..." is showing up later.
  • Having \. in a python string is triggering pylint warnings, because it should be escaped as a regex string, e.g. r'\.' However, . in a character class does not need to be escaped, as it matches only a literal .` in that context.

Diff Detail

Event Timeline

rupprecht created this revision.Sep 21 2020, 3:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2020, 3:22 PM
rupprecht requested review of this revision.Sep 21 2020, 3:22 PM
JDevlieghere accepted this revision.Sep 21 2020, 3:31 PM
This revision is now accepted and ready to land.Sep 21 2020, 3:31 PM
This revision was automatically updated to reflect the committed changes.