Page MenuHomePhabricator

Update sys.platform switched behavior in tests to use self.getPlatform (remote target platform)
ClosedPublic

Authored by flackr on Mar 31 2015, 1:40 PM.

Details

Summary

Uses target platform when determining which platform specific behavior to use or expect in tests. TestHelp.py was unchanged because this is asserting behavior of the local lldb binary.

Diff Detail

Repository
rL LLVM

Event Timeline

flackr updated this revision to Diff 23006.Mar 31 2015, 1:40 PM
flackr retitled this revision from to Update sys.platform switched behavior in tests to use self.getPlatform (remote target platform).
flackr updated this object.
flackr edited the test plan for this revision. (Show Details)
flackr added a reviewer: clayborg.
flackr set the repository for this revision to rL LLVM.
flackr added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Mar 31 2015, 2:11 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2015, 2:11 PM
emaste accepted this revision.Mar 31 2015, 2:21 PM
emaste added a reviewer: emaste.
emaste added a subscriber: emaste.

lgtm

test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
218 ↗(On Diff #23006)

should we change these cases to be if (self.getPlatform() != "darwin")?

test/functionalities/load_unload/TestLoadUnload.py
41 ↗(On Diff #23006)

Independent of this change, seems like this test would benefit from a little refactoring

test/functionalities/register/TestRegisters.py
92 ↗(On Diff #23006)

same comment about refactoring

This revision was automatically updated to reflect the committed changes.