diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -3861,6 +3861,7 @@ const auto *II = dyn_cast_or_null(CLI.CB); bool HasNoCfCheck = (CI && CI->doesNoCfCheck()) || (II && II->doesNoCfCheck()); + bool IsIndirectCall = (CI && CI->isIndirectCall()); const Module *M = MF.getMMI().getModule(); Metadata *IsCFProtectionSupported = M->getModuleFlag("cf-protection-branch"); @@ -4343,7 +4344,7 @@ return Ret; } - if (HasNoCfCheck && IsCFProtectionSupported) { + if (HasNoCfCheck && IsCFProtectionSupported && IsIndirectCall) { Chain = DAG.getNode(X86ISD::NT_CALL, dl, NodeTys, Ops); } else { Chain = DAG.getNode(X86ISD::CALL, dl, NodeTys, Ops); diff --git a/llvm/test/CodeGen/X86/nocf_check.ll b/llvm/test/CodeGen/X86/nocf_check.ll --- a/llvm/test/CodeGen/X86/nocf_check.ll +++ b/llvm/test/CodeGen/X86/nocf_check.ll @@ -10,6 +10,7 @@ ;; void NoCfCheckCall(FuncPointer f) { ;; ;; __attribute__((nocf_check)) FuncPointer p = f; ;; ;; (*p)(); ;; +;; NoCfCheckFunc(); ;; ;; } ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; @@ -23,10 +24,13 @@ ret void } -; Make sure that notrack prefix is added before a call with ''nocf_check'' attribute. -define void @NoCfCheckCall(void ()* %f) { +; Ensure the notrack prefix is added before an indirect call using a pointer +; with ''nocf_check'' attribute. Also ensure a direct call to a function with +; the ''nocf_check'' attribute is correctly generated without notrack prefix. +define void @NoCfCheckCall(void ()* %f) #1 { ; CHECK-LABEL: NoCfCheckCall ; CHECK: notrack call +; CHECK: callq NoCfCheckFunc entry: %f.addr = alloca void ()*, align 4 %p = alloca void ()*, align 4 @@ -34,12 +38,14 @@ %0 = load void ()*, void ()** %f.addr, align 4 store void ()* %0, void ()** %p, align 4 %1 = load void ()*, void ()** %p, align 4 - call void %1() #1 + call void %1() #2 + call void @NoCfCheckFunc() #2 ret void } -attributes #0 = { noinline nocf_check nounwind optnone "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="none" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-features"="+x87" "unsafe-fp-math"="false" "use-soft-float"="false" } -attributes #1 = { nocf_check } +attributes #0 = { nocf_check noinline nounwind optnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" "unsafe-fp-math"="false" "use-soft-float"="false" } +attributes #1 = { noinline nounwind optnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" "unsafe-fp-math"="false" "use-soft-float"="false" } +attributes #2 = { nocf_check } !llvm.module.flags = !{!0}