diff --git a/llvm/lib/IR/Attributes.cpp b/llvm/lib/IR/Attributes.cpp --- a/llvm/lib/IR/Attributes.cpp +++ b/llvm/lib/IR/Attributes.cpp @@ -1848,6 +1848,7 @@ .addAttribute(Attribute::NoAlias) .addAttribute(Attribute::NoCapture) .addAttribute(Attribute::NonNull) + .addAlignmentAttr(1) // the int here is ignored .addDereferenceableAttr(1) // the int here is ignored .addDereferenceableOrNullAttr(1) // the int here is ignored .addAttribute(Attribute::ReadNone) diff --git a/llvm/test/Bitcode/attributes-3.3.ll b/llvm/test/Bitcode/attributes-3.3.ll --- a/llvm/test/Bitcode/attributes-3.3.ll +++ b/llvm/test/Bitcode/attributes-3.3.ll @@ -101,8 +101,8 @@ ret void; } -define void @f17(i8 align 4 %0) -; CHECK: define void @f17(i8 align 4 %0) +define void @f17(i8* align 4 %0) +; CHECK: define void @f17(i8* align 4 %0) { ret void; } diff --git a/llvm/test/Bitcode/attributes.ll b/llvm/test/Bitcode/attributes.ll --- a/llvm/test/Bitcode/attributes.ll +++ b/llvm/test/Bitcode/attributes.ll @@ -98,8 +98,8 @@ ret void; } -define void @f17(i8 align 4 %0) -; CHECK: define void @f17(i8 align 4 %0) +define void @f17(i8* align 4 %0) +; CHECK: define void @f17(i8* align 4 %0) { ret void; } diff --git a/llvm/test/Transforms/DeadArgElim/returned.ll b/llvm/test/Transforms/DeadArgElim/returned.ll --- a/llvm/test/Transforms/DeadArgElim/returned.ll +++ b/llvm/test/Transforms/DeadArgElim/returned.ll @@ -43,6 +43,12 @@ ret %Ty* %this } +; Drop all these attributes +; CHECK-LABEL: define internal void @test6 +define internal align 8 dereferenceable_or_null(2) noalias i8* @test6() { + ret i8* null +} + define %Ty* @caller(%Ty* %this) { %1 = call %Ty* @test1(%Ty* %this) %2 = call %Ty* @test2(%Ty* %this) @@ -51,5 +57,6 @@ ; ...instead, drop 'returned' form the call site ; CHECK: call void @test5(%Ty* %this) %5 = call %Ty* @test5(%Ty* returned %this) + %6 = call i8* @test6() ret %Ty* %this } diff --git a/llvm/test/Transforms/LoopSimplify/unreachable-loop-pred.ll b/llvm/test/Transforms/LoopSimplify/unreachable-loop-pred.ll --- a/llvm/test/Transforms/LoopSimplify/unreachable-loop-pred.ll +++ b/llvm/test/Transforms/LoopSimplify/unreachable-loop-pred.ll @@ -22,7 +22,7 @@ ; When loopsimplify generates dedicated exit block for blocks that are landing ; pads (i.e. innerLoopExit in this test), we should not get confused with the ; unreachable pred (unreachableB) to innerLoopExit. -define align 8 void @baz(i32 %trip) personality i32* ()* @wobble { +define void @baz(i32 %trip) personality i32* ()* @wobble { entry: br label %outerHeader diff --git a/llvm/test/Verifier/align.ll b/llvm/test/Verifier/align.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Verifier/align.ll @@ -0,0 +1,13 @@ +; RUN: not llvm-as < %s -o /dev/null 2>&1 | FileCheck %s + +; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly sret byref(i32) byval(i32) preallocated(i32) align 1 dereferenceable(1) dereferenceable_or_null(1) +; CHECK-NEXT: @align_non_pointer1 +define void @align_non_pointer1(i32 align 4 %a) { + ret void +} + +; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly signext sret zeroext byref(void) byval(void) preallocated(void) align 1 dereferenceable(1) dereferenceable_or_null(1) +; CHECK-NEXT: @align_non_pointer2 +define align 4 void @align_non_pointer2(i32 %a) { + ret void +} diff --git a/llvm/test/Verifier/byref.ll b/llvm/test/Verifier/byref.ll --- a/llvm/test/Verifier/byref.ll +++ b/llvm/test/Verifier/byref.ll @@ -56,7 +56,7 @@ ret void } -; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly sret byref(i32) byval(i32) preallocated(i32) dereferenceable(1) dereferenceable_or_null(1) +; CHECK: Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly sret byref(i32) byval(i32) preallocated(i32) align 1 dereferenceable(1) dereferenceable_or_null(1) ; CHECK-NEXT: void (i32)* @byref_non_pointer define void @byref_non_pointer(i32 byref(i32)) { ret void