Page MenuHomePhabricator

[libunwind] Fix a few libunwind includes
ClosedPublic

Authored by ldionne on Aug 28 2020, 12:50 AM.

Details

Summary

In UnwindCursor.hpp, include config.h before checking
_LIBUNWIND_SUPPORT_SEH_UNWIND.

Include libunwind_ext.h for UNW_STEP_SUCCESS.

Diff Detail

Event Timeline

rprichard created this revision.Aug 28 2020, 12:50 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 28 2020, 12:50 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
rprichard requested review of this revision.Aug 28 2020, 12:50 AM

On second thought, maybe I don't actually need this change, and the includes still seem like a mess in libunwind. Maybe it makes more sense to do a larger revision eventually.

This seems relatively harmless, not sure if its valuable though.

MaskRay accepted this revision.Jun 30 2022, 12:25 PM
MaskRay added a subscriber: MaskRay.

... so that it no longer shows on my review queue. I think this is still worth doing, especially the weird include places in UnwindCursor.hpp might confuse readers.

This revision is now accepted and ready to land.Jun 30 2022, 12:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2022, 12:25 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
ldionne commandeered this revision.Wed, Sep 7, 2:27 PM
ldionne added a reviewer: rprichard.
ldionne added a subscriber: ldionne.

Commandeering to rebase and land.

ldionne updated this revision to Diff 458563.Wed, Sep 7, 2:30 PM

Here we go -- rebase onto main. I'll land once CI is green.

phosek accepted this revision.Wed, Sep 7, 4:56 PM
phosek added a subscriber: phosek.

LGTM

rprichard accepted this revision.Wed, Sep 7, 5:11 PM
MaskRay accepted this revision.Wed, Sep 7, 6:29 PM
This revision was landed with ongoing or failed builds.Wed, Sep 7, 7:18 PM
This revision was automatically updated to reflect the committed changes.