diff --git a/llvm/lib/Transforms/Scalar/Scalarizer.cpp b/llvm/lib/Transforms/Scalar/Scalarizer.cpp --- a/llvm/lib/Transforms/Scalar/Scalarizer.cpp +++ b/llvm/lib/Transforms/Scalar/Scalarizer.cpp @@ -941,13 +941,13 @@ for (unsigned I = 0; I < Count; ++I) Res = Builder.CreateInsertElement(Res, CV[I], Builder.getInt32(I), Op->getName() + ".upto" + Twine(I)); + Res->takeName(Op); } else { assert(CV.size() == 1 && Op->getType() == CV[0]->getType()); Res = CV[0]; if (Op == Res) continue; } - Res->takeName(Op); Op->replaceAllUsesWith(Res); } PotentiallyDeadInstrs.emplace_back(Op); diff --git a/llvm/test/Transforms/Scalarizer/basic.ll b/llvm/test/Transforms/Scalarizer/basic.ll --- a/llvm/test/Transforms/Scalarizer/basic.ll +++ b/llvm/test/Transforms/Scalarizer/basic.ll @@ -542,8 +542,8 @@ ; See https://reviews.llvm.org/D83101#2133062 define <2 x i32> @f23_crash(<2 x i32> %srcvec, i32 %v1) { ; CHECK-LABEL: @f23_crash( -; CHECK: %1 = extractelement <2 x i32> %srcvec, i32 0 -; CHECK: %t1.upto0 = insertelement <2 x i32> undef, i32 %1, i32 0 +; CHECK: %v0 = extractelement <2 x i32> %srcvec, i32 0 +; CHECK: %t1.upto0 = insertelement <2 x i32> undef, i32 %v0, i32 0 ; CHECK: %t1 = insertelement <2 x i32> %t1.upto0, i32 %v1, i32 1 ; CHECK: ret <2 x i32> %t1 %v0 = extractelement <2 x i32> %srcvec, i32 0 diff --git a/llvm/test/Transforms/Scalarizer/global-bug.ll b/llvm/test/Transforms/Scalarizer/global-bug.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Transforms/Scalarizer/global-bug.ll @@ -0,0 +1,23 @@ +; RUN: opt < %s -scalarizer -S -o - | FileCheck %s +; RUN: opt < %s -passes='function(scalarizer)' -S | FileCheck %s + +@a = dso_local global i16 0, align 1 +@b = dso_local local_unnamed_addr global i16 0, align 1 + +; The scalarizer used to take the name of the extractelement instruction +; ("extract") and put that on the extracted value, which in this test case is +; the global variable @a. That was wrong, as we must not change the name of +; the global variable. So make sure we find "@a" in the ptrtoint. +define dso_local void @test1() local_unnamed_addr { +; CHECK-LABEL: @test1( +; CHECK-NEXT: entry: +; CHECK-NEXT: [[T0:%.*]] = ptrtoint i16* @a to i16 +; CHECK-NEXT: store i16 [[T0]], i16* @b, align 1 +; CHECK-NEXT: ret void +; +entry: + %extract = extractelement <4 x i16*> , i32 1 + %t0 = ptrtoint i16* %extract to i16 + store i16 %t0, i16* @b, align 1 + ret void +}