This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Update TestSimulatorPlatform.py now that the Makefile no longer decomposes the TRIPLE
ClosedPublic

Authored by JDevlieghere on Aug 19 2020, 1:33 PM.

Details

Summary

We move the triple (de)composition logic into the builder in e5d08fcbac72 but this test is relying on Make to construct the ARCH_CFLAGS from the given TRIPLE. This updates the test to pass ARC, ARCH_CFLAGS and SDKROOT instead.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Aug 19 2020, 1:33 PM
JDevlieghere created this revision.
aprantl accepted this revision.Aug 19 2020, 2:17 PM

I just learned that we no longer compute SDKROOT in Makefile.rules, so this seems resonable.

This revision is now accepted and ready to land.Aug 19 2020, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2020, 3:43 PM