diff --git a/compiler-rt/lib/dfsan/dfsan_interceptors.cpp b/compiler-rt/lib/dfsan/dfsan_interceptors.cpp --- a/compiler-rt/lib/dfsan/dfsan_interceptors.cpp +++ b/compiler-rt/lib/dfsan/dfsan_interceptors.cpp @@ -11,15 +11,25 @@ // Interceptors for standard library functions. //===----------------------------------------------------------------------===// +#include +#include + #include "dfsan/dfsan.h" #include "interception/interception.h" #include "sanitizer_common/sanitizer_common.h" using namespace __sanitizer; +static bool interceptors_initialized; + INTERCEPTOR(void *, mmap, void *addr, SIZE_T length, int prot, int flags, int fd, OFF_T offset) { - void *res = REAL(mmap)(addr, length, prot, flags, fd, offset); + void *res; + if (!interceptors_initialized) + res = (void*)syscall(__NR_mmap, addr, length, prot, flags, fd, offset); + else + res = REAL(mmap)(addr, length, prot, flags, fd, offset); + if (res != (void*)-1) dfsan_set_label(0, res, RoundUpTo(length, GetPageSize())); return res; @@ -35,11 +45,11 @@ namespace __dfsan { void InitializeInterceptors() { - static int inited = 0; - CHECK_EQ(inited, 0); + CHECK(!interceptors_initialized); INTERCEPT_FUNCTION(mmap); INTERCEPT_FUNCTION(mmap64); - inited = 1; + + interceptors_initialized = true; } } // namespace __dfsan diff --git a/compiler-rt/test/dfsan/interceptors.c b/compiler-rt/test/dfsan/interceptors.c new file mode 100644 --- /dev/null +++ b/compiler-rt/test/dfsan/interceptors.c @@ -0,0 +1,32 @@ +// RUN: %clang_dfsan -fno-sanitize=dataflow -DCALLOC -c %s -o %t-calloc.o +// RUN: %clang_dfsan %s %t-calloc.o -o %t +// RUN: %run %t +// +// Tests that calling mmap() during during dfsan initialization works. + +#include +#include +#include +#include +#include + +#ifdef CALLOC + +// dfsan_init() installs interceptors via dlysm(), which calls calloc(). +// Calling mmap() from here should work even if interceptors haven't been fully +// set up yet. +void *calloc(size_t Num, size_t Size) { + size_t PageSize = getpagesize(); + Size = Size * Num; + Size = (Size + PageSize - 1) & ~(PageSize - 1); // Round up to PageSize. + void *Ret = mmap(NULL, Size, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + assert(Ret != MAP_FAILED); + return Ret; +} + +#else + +int main() { return 0; } + +#endif // CALLOC