This is an archive of the discontinued LLVM Phabricator instance.

Differential D85979

[llvm-zorg] PowerPC Fixing Malformed LIT Flag
ClosedPublic

Authored by zacharyselk on Aug 14 2020, 10:19 AM.

Details

Reviewers
nemanjai
kamaub
gkistanova
Commits
rZORG9200ad6bba3d: [llvm-zorg] PowerPC Fixing Malformed LIT Flag
Summary

Fixing the -j LIT argument so that it can be parsed proporly

Diff Detail

Event Timeline

zacharyselk created this revision.Aug 14 2020, 10:19 AM
Herald added a reviewer: gkistanova. · View Herald TranscriptAug 14 2020, 10:19 AM
Herald added a subscriber: shchenz. · View Herald Transcript
zacharyselk requested review of this revision.Aug 14 2020, 10:19 AM
Harbormaster completed remote builds in B68427: Diff 285683.Aug 14 2020, 10:19 AM
nemanjai accepted this revision.Aug 14 2020, 10:59 AM

LGTM. Thanks for fixing this. Hopefully we can get this committed quickly to bring the LLD bot back to green.

This revision is now accepted and ready to land.Aug 14 2020, 10:59 AM
Closed by commit rZORG9200ad6bba3d: [llvm-zorg] PowerPC Fixing Malformed LIT Flag (authored by zacharyselk). · Explain WhyAug 14 2020, 11:21 AM
This revision was automatically updated to reflect the committed changes.
zacharyselk added a commit: rZORG9200ad6bba3d: [llvm-zorg] PowerPC Fixing Malformed LIT Flag.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
8 lines

Diff 285696

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 550 Lines • ▼ Show 20 Lines return [
runTestSuite=True, runTestSuite=True,
stage1_config='Release', stage1_config='Release',
nt_flags=['--threads=16', '--build-threads=16'], nt_flags=['--threads=16', '--build-threads=16'],
extra_cmake_args=["-DLLVM_ENABLE_ASSERTIONS=On", "-DCMAKE_C_COMPILER=clang", extra_cmake_args=["-DLLVM_ENABLE_ASSERTIONS=On", "-DCMAKE_C_COMPILER=clang",
"-DCMAKE_CXX_COMPILER=clang++", "-DCMAKE_CXX_COMPILER=clang++",
"-DCMAKE_C_COMPILER_EXTERNAL_TOOLCHAIN:PATH=/opt/rh/devtoolset-7/root/usr", "-DCMAKE_C_COMPILER_EXTERNAL_TOOLCHAIN:PATH=/opt/rh/devtoolset-7/root/usr",
"-DCMAKE_CXX_COMPILER_EXTERNAL_TOOLCHAIN:PATH=/opt/rh/devtoolset-7/root/usr", "-DCMAKE_CXX_COMPILER_EXTERNAL_TOOLCHAIN:PATH=/opt/rh/devtoolset-7/root/usr",
"-DLLVM_BINUTILS_INCDIR=/usr/include", "-DBUILD_SHARED_LIBS=ON", "-DLLVM_ENABLE_WERROR=ON", "-DLLVM_BINUTILS_INCDIR=/usr/include", "-DBUILD_SHARED_LIBS=ON", "-DLLVM_ENABLE_WERROR=ON",
'-DLLVM_LIT_ARGS="-v -j256"']), '-DLLVM_LIT_ARGS="-vj 256"']),
'category' : 'clang'}, 'category' : 'clang'},
{'name': "clang-s390x-linux", {'name': "clang-s390x-linux",
'slavenames':["systemz-1"], 'slavenames':["systemz-1"],
'builddir':"clang-s390x-linux", 'builddir':"clang-s390x-linux",
'factory' : ClangBuilder.getClangCMakeBuildFactory(jobs=4, 'factory' : ClangBuilder.getClangCMakeBuildFactory(jobs=4,
clean=False, clean=False,
checkout_lld=False, checkout_lld=False,
▲ Show 20 Lines • Show All 492 Lines • ▼ Show 20 Lines return [
'category' : 'lld'}, 'category' : 'lld'},
{'name' : "ppc64le-lld-multistage-test", {'name' : "ppc64le-lld-multistage-test",
'slavenames' : ["ppc64le-lld-multistage-test"], 'slavenames' : ["ppc64le-lld-multistage-test"],
'builddir' : "ppc64le-lld-multistage-test", 'builddir' : "ppc64le-lld-multistage-test",
'factory': UnifiedTreeBuilder.getCmakeWithNinjaMultistageBuildFactory( 'factory': UnifiedTreeBuilder.getCmakeWithNinjaMultistageBuildFactory(
extra_configure_args=[ extra_configure_args=[
'-DLLVM_ENABLE_ASSERTIONS=ON', '-DLLVM_ENABLE_ASSERTIONS=ON',
'-DLLVM_LIT_ARGS="-sv -j256"'], '-DLLVM_LIT_ARGS="-svj 256"'],
depends_on_projects=['llvm', 'clang', 'lld']), depends_on_projects=['llvm', 'clang', 'lld']),
'category' : 'lld'}, 'category' : 'lld'},
{'name' : "lld-x86_64-ubuntu-fast", {'name' : "lld-x86_64-ubuntu-fast",
'slavenames' : ["as-builder-4"], 'slavenames' : ["as-builder-4"],
'builddir' : "lld-x86_64-ubuntu-fast", 'builddir' : "lld-x86_64-ubuntu-fast",
'mergeRequests': False, 'mergeRequests': False,
'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( 'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines return [
clean=True, clean=True,
depends_on_projects=['llvm', 'mlir'], depends_on_projects=['llvm', 'mlir'],
checks=['check-mlir'], checks=['check-mlir'],
extra_configure_args=[ extra_configure_args=[
'-DLLVM_TARGETS_TO_BUILD=PowerPC', '-DLLVM_TARGETS_TO_BUILD=PowerPC',
'-DLLVM_INSTALL_UTILS=ON', '-DLLVM_INSTALL_UTILS=ON',
'-DCMAKE_CXX_STANDARD=17', '-DCMAKE_CXX_STANDARD=17',
'-DLLVM_ENABLE_PROJECTS="mlir"', '-DLLVM_ENABLE_PROJECTS="mlir"',
'-DLLVM_LIT_ARGS="-v -j256"', '-DLLVM_LIT_ARGS="-vj 256"',
], ],
env={ env={
'CC': 'clang', 'CC': 'clang',
'CXX': 'clang++', 'CXX': 'clang++',
'LD': 'lld', 'LD': 'lld',
})}, })},
] ]
▲ Show 20 Lines • Show All 464 Lines • ▼ Show 20 Lines return [
clean=True, clean=True,
depends_on_projects=['llvm', 'mlir', 'clang', 'flang'], depends_on_projects=['llvm', 'mlir', 'clang', 'flang'],
checks=['check-flang'], checks=['check-flang'],
extra_configure_args=[ extra_configure_args=[
'-DLLVM_TARGETS_TO_BUILD=PowerPC', '-DLLVM_TARGETS_TO_BUILD=PowerPC',
'-DLLVM_INSTALL_UTILS=ON', '-DLLVM_INSTALL_UTILS=ON',
'-DCMAKE_CXX_STANDARD=17', '-DCMAKE_CXX_STANDARD=17',
'-DLLVM_ENABLE_PROJECTS="flang"', '-DLLVM_ENABLE_PROJECTS="flang"',
'-DLLVM_LIT_ARGS="-v -j256"' '-DLLVM_LIT_ARGS="-vj 256"'
], ],
env={ env={
'CC': 'clang', 'CC': 'clang',
'CXX': 'clang++', 'CXX': 'clang++',
'LD': 'lld' 'LD': 'lld'
}), }),
'category': 'flang'}, 'category': 'flang'},
] ]
▲ Show 20 Lines • Show All 229 Lines • Show Last 20 Lines