This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Fix typo and variable names
ClosedPublic

Authored by hiraditya on Aug 14 2020, 9:08 AM.

Details

Diff Detail

Event Timeline

hiraditya created this revision.Aug 14 2020, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2020, 9:08 AM
hiraditya requested review of this revision.Aug 14 2020, 9:08 AM
jfb accepted this revision.Aug 14 2020, 10:34 AM

The typo fix is fine, I'm not sure it's worth fixing variable names (since there's an ongoing discussion about renaming everything anyways).
FWIW C++ doesn't really have a lattice anymore: https://wg21.link/p0418

This revision is now accepted and ready to land.Aug 14 2020, 10:34 AM

FWIW C++ doesn't really have a lattice anymore: https://wg21.link/p0418

Is there a guidance for the users of 'isStrongerThan', isStrongerThanUnordered etc.?