Index: llvm/test/TableGen/MixedCasedMnemonic.td =================================================================== --- /dev/null +++ llvm/test/TableGen/MixedCasedMnemonic.td @@ -0,0 +1,55 @@ +// RUN: llvm-tblgen -gen-asm-matcher -I %p/../../include %s | FileCheck %s --check-prefix=MATCHER +// RUN: llvm-tblgen -gen-asm-writer -I %p/../../include %s | FileCheck %s --check-prefix=WRITER + +// Check that an instruction that uses mixed upper/lower case in its mnemonic +// is printed as-is, and is parsed in its "canonicalized" lowercase form. + +include "llvm/Target/Target.td" + +def ArchInstrInfo : InstrInfo { } + +def Arch : Target { + let InstructionSet = ArchInstrInfo; +} + +def Reg : Register<"reg">; +def RegClass : RegisterClass<"foo", [i32], 0, (add Reg)>; + +// Define instructions that demonstrate case-insensitivity. +// In case-sensitive ASCII order, "BInst" < "aInst". +// In case-insensitive order, "aInst" < "BInst". +// If the matcher really treats the mnemonics in a case-insensitive way, +// then we should see "aInst" appearing before "BInst", despite the +// fact that "BInst" would appear before "aInst" in ASCIIbetical order. +def AlphabeticallySecondInst : Instruction { + let Size = 2; + let OutOperandList = (outs); + let InOperandList = (ins); + let AsmString = "BInst"; +} + +def AlphabeticallyFirstInst : Instruction { + let Size = 2; + let OutOperandList = (outs); + let InOperandList = (ins); + let AsmString = "aInst"; +} + +// Check that the matcher lower()s the mnemonics it matches. +// MATCHER: static const char *const MnemonicTable = +// MATCHER-NEXT: "\005ainst\005binst"; + +// Check that aInst appears before BInst in the match table. +// This shows that the mnemonics are sorted in a case-insensitive way, +// since otherwise "B" would be less than "a" by ASCII order. +// MATCHER: static const MatchEntry MatchTable0[] = { +// MATCHER-NEXT: /* aInst */, ::AlphabeticallyFirstInst +// MATCHER-NEXT: /* BInst */, ::AlphabeticallySecondInst +// MATCHER-NEXT: }; + +// Check that the writer preserves the case of the mnemonics. +// WRITER: static const char AsmStrs[] = { +// WRITER: "BInst\0" +// WRITER-NEXT: "aInst\0" +// WRITER-NEXT: }; + Index: llvm/utils/TableGen/AsmMatcherEmitter.cpp =================================================================== --- llvm/utils/TableGen/AsmMatcherEmitter.cpp +++ llvm/utils/TableGen/AsmMatcherEmitter.cpp @@ -612,7 +612,7 @@ /// operator< - Compare two matchables. bool operator<(const MatchableInfo &RHS) const { // The primary comparator is the instruction mnemonic. - if (int Cmp = Mnemonic.compare(RHS.Mnemonic)) + if (int Cmp = Mnemonic.compare_lower(RHS.Mnemonic)) return Cmp == -1; if (AsmOperands.size() != RHS.AsmOperands.size()) @@ -2880,7 +2880,7 @@ OS << " { "; // Store a pascal-style length byte in the mnemonic. - std::string LenMnemonic = char(II.Mnemonic.size()) + II.Mnemonic.str(); + std::string LenMnemonic = char(II.Mnemonic.size()) + II.Mnemonic.lower(); OS << StringTable.GetOrAddStringOffset(LenMnemonic, false) << " /* " << II.Mnemonic << " */, "; @@ -3324,7 +3324,7 @@ HasDeprecation |= MI->HasDeprecation; // Store a pascal-style length byte in the mnemonic. - std::string LenMnemonic = char(MI->Mnemonic.size()) + MI->Mnemonic.str(); + std::string LenMnemonic = char(MI->Mnemonic.size()) + MI->Mnemonic.lower(); MaxMnemonicIndex = std::max(MaxMnemonicIndex, StringTable.GetOrAddStringOffset(LenMnemonic, false)); } @@ -3438,7 +3438,8 @@ continue; // Store a pascal-style length byte in the mnemonic. - std::string LenMnemonic = char(MI->Mnemonic.size()) + MI->Mnemonic.str(); + std::string LenMnemonic = + char(MI->Mnemonic.size()) + MI->Mnemonic.lower(); OS << " { " << StringTable.GetOrAddStringOffset(LenMnemonic, false) << " /* " << MI->Mnemonic << " */, " << Target.getInstNamespace() << "::"