Page MenuHomePhabricator

Fix ModuleCache usage in Platform - ask remote platform for module's ModuleSpec beforehand so we can look for a module by UUID locally without need to download it.
ClosedPublic

Authored by ovyalov on Mar 23 2015, 11:09 AM.

Details

Summary

Previous implementation caused TestGlobalVariables to fail when running remote Linux<->Linux test - test creates a module for shared library in registerSharedLibrariesWithTarget.
The test was failing because a copy of shared library was downloaded into module cache from remote target instead of using existing local module instance - with this patch in we can lookup a module in ModuleList by known UUID and switch to already registered module instance if such exists.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 22490.Mar 23 2015, 11:09 AM
ovyalov retitled this revision from to Fix ModuleCache usage in Platform - ask remote platform for module's ModuleSpec beforehand so we can look for a module by UUID locally without need to download it..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added reviewers: clayborg, vharron, tberghammer.
ovyalov added a subscriber: Unknown Object (MLST).
tberghammer accepted this revision.Mar 24 2015, 9:15 AM
tberghammer edited edge metadata.

Looks good, but please be careful when rebaseing it to TOT because there will be a lot of conflicts.

BTW it also fixes an issue related to TestInferiorChanged.

This revision is now accepted and ready to land.Mar 24 2015, 9:15 AM
clayborg accepted this revision.Mar 24 2015, 9:59 AM
clayborg edited edge metadata.

lgtm

ovyalov closed this revision.Mar 24 2015, 4:55 PM

AFFECTED FILES

/lldb/trunk/include/lldb/Target/Platform.h
/lldb/trunk/source/Target/Platform.cpp
/lldb/trunk/source/Utility/ModuleCache.cpp
/lldb/trunk/source/Utility/ModuleCache.h

USERS

ovyalov (Author)

http://reviews.llvm.org/rL233136