Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D85370

[mlir][Attribute] Remove usages of Attribute::getKind
ClosedPublic
Actions

Authored by rriddle on Aug 5 2020, 3:50 PM.

Details

Reviewers
jpienaar
mehdi_amini
ftynse
mravishankar
antiagainst
jdoerfert
Commits
rGfff39b62bb40: [mlir][Attribute] Remove usages of Attribute::getKind
Summary

This is in preparation for removing the use of "kinds" within attributes and types in MLIR.

Depends On D85356

Diff Detail

Event Timeline

rriddle created this revision.Aug 5 2020, 3:50 PM
Herald added a reviewer: mravishankar. · View Herald TranscriptAug 5 2020, 3:50 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: jdoerfert. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: AlexeySotkin, msifontes, jurahul and 10 others. · View Herald Transcript
rriddle requested review of this revision.Aug 5 2020, 3:50 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptAug 5 2020, 3:50 PM
Harbormaster completed remote builds in B67217: Diff 283430.Aug 5 2020, 5:19 PM
jdoerfert resigned from this revision.Aug 5 2020, 8:29 PM

wrong attribute file ;)

mehdi_amini accepted this revision.Aug 5 2020, 9:21 PM
mehdi_amini added inline comments.
mlir/include/mlir/IR/Attributes.h
1510

Clang-format?

This revision is now accepted and ready to land.Aug 5 2020, 9:21 PM
bondhugula added a subscriber: bondhugula.Aug 5 2020, 11:56 PM
bondhugula added inline comments.
mlir/lib/IR/AsmPrinter.cpp
1075

Nit: prefer avoiding auto here.

rriddle updated this revision to Diff 283738.Aug 6 2020, 2:45 PM
rriddle marked 2 inline comments as done.

Resolve comments

rriddle added a child revision: D85475: [mlir][Type] Remove usages of Type::getKind.Aug 6 2020, 2:45 PM
Harbormaster completed remote builds in B67377: Diff 283738.Aug 6 2020, 2:59 PM
This revision was landed with ongoing or failed builds.Aug 7 2020, 1:44 PM
Closed by commit rGfff39b62bb40: [mlir][Attribute] Remove usages of Attribute::getKind (authored by rriddle). · Explain Why
This revision was automatically updated to reflect the committed changes.
rriddle added a commit: rGfff39b62bb40: [mlir][Attribute] Remove usages of Attribute::getKind.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
IR/
41 lines
5 lines
lib/
Dialect/
SPIRV/
41 lines
IR/
280 lines
44 lines
27 lines
10 lines
Target/
LLVMIR/
30 lines
unittests/
Dialect/
Quant/
2 lines

Diff 284034

View Options

mlir/include/mlir/IR/Attributes.h

Loading...
View Options

mlir/include/mlir/IR/Location.h

Loading...
View Options

mlir/lib/Dialect/SPIRV/SPIRVOps.cpp

Loading...
View Options

mlir/lib/IR/AsmPrinter.cpp

Loading...
View Options

mlir/lib/IR/Attributes.cpp

Loading...
View Options

mlir/lib/IR/Diagnostics.cpp

Loading...
View Options

mlir/lib/IR/Location.cpp

Loading...
View Options

mlir/lib/Target/LLVMIR/DebugTranslation.cpp

Loading...
View Options

mlir/unittests/Dialect/Quant/QuantizationUtilsTest.cpp

Loading...