diff --git a/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h b/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h --- a/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h +++ b/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h @@ -89,13 +89,13 @@ const LowerToLLVMOptions &getOptions() const { return options; } - /// Promote the LLVM struct representation of all MemRef descriptors to stack - /// and use pointers to struct to avoid the complexity of the - /// platform-specific C/C++ ABI lowering related to struct argument passing. - SmallVector promoteMemRefDescriptors(Location loc, - ValueRange opOperands, - ValueRange operands, - OpBuilder &builder); + /// Promote the LLVM representation of all operands including promoting MemRef + /// descriptors to stack and use pointers to struct to avoid the complexity + /// of the platform-specific C/C++ ABI lowering related to struct argument + /// passing. + SmallVector promoteOperands(Location loc, ValueRange opOperands, + ValueRange operands, + OpBuilder &builder); /// Promote the LLVM struct representation of one MemRef descriptor to stack /// and use pointer to struct to avoid the complexity of the platform-specific diff --git a/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp b/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp --- a/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp +++ b/mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp @@ -2126,7 +2126,7 @@ return failure(); } - auto promoted = this->typeConverter.promoteMemRefDescriptors( + auto promoted = this->typeConverter.promoteOperands( op->getLoc(), /*opOperands=*/op->getOperands(), operands, rewriter); auto newOp = rewriter.create(op->getLoc(), packedResult, promoted, op->getAttrs()); @@ -3356,10 +3356,10 @@ return allocated; } -SmallVector -LLVMTypeConverter::promoteMemRefDescriptors(Location loc, ValueRange opOperands, - ValueRange operands, - OpBuilder &builder) { +SmallVector LLVMTypeConverter::promoteOperands(Location loc, + ValueRange opOperands, + ValueRange operands, + OpBuilder &builder) { SmallVector promotedOperands; promotedOperands.reserve(operands.size()); for (auto it : llvm::zip(opOperands, operands)) {