Page MenuHomePhabricator

Don't claim exception related arguments when looking at RTTIMode
ClosedPublic

Authored by filcab on Mar 20 2015, 3:46 PM.

Details

Summary

We were claiming the -f*exceptions arguments when looking for the
RTTIMode. This makes us not warn about unused arguments if compiling a C
file with -fcxx-exceptions.

This patch fixes it by not claiming the exception-related arguments at
that point.

Diff Detail

Repository
rL LLVM

Event Timeline

filcab updated this revision to Diff 22392.Mar 20 2015, 3:46 PM
filcab retitled this revision from to Don't claim exception related arguments when looking at RTTIMode.
filcab updated this object.
filcab edited the test plan for this revision. (Show Details)
filcab added reviewers: rsmith, samsonov.
filcab added a subscriber: Unknown Object (MLST).
filcab updated this revision to Diff 22394.Mar 20 2015, 3:53 PM

Fix the test by actually forcing the test's special case to treat it as a C file

samsonov accepted this revision.Mar 20 2015, 3:54 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 20 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.