Page MenuHomePhabricator

[intel-pt] Fix python support and add a full python test
AbandonedPublic

Authored by wallace on Jul 28 2020, 12:44 PM.

Details

Summary

The initial implementation of the Intel PT support for LLDB came with
some Python support. However, when LLDB was upgraded to more modern versions of
SWIG and Python3, the Intel Pt Python API broke and has not been updated since
then.
This makes me believe that no one has used that API in a looong time.

As a fix, I replicated some fixes done in the core LLDB Python support.
Additionally, I added a test that uses entirely the Intel PT Python API and made
some additional fixes to the existing test.

I'm not fond of the existing API design, so I'll be improving it in following
diffs.

Diff Detail

Event Timeline

wallace created this revision.Jul 28 2020, 12:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 12:44 PM
wallace requested review of this revision.Jul 28 2020, 12:44 PM
wallace added inline comments.Jul 28 2020, 12:46 PM
lldb/source/API/SBDebugger.cpp
66–69

I'm adding this small change, which helped a lot to figure out some issues when loading the intel plugin shared object. I hope you don't mind.

wallace updated this revision to Diff 281334.Jul 28 2020, 12:59 PM

fix incorrect comment

Harbormaster completed remote builds in B66079: Diff 281334.
wallace abandoned this revision.Aug 3 2020, 3:00 PM

After syncing up with Greg, we decided to redo this in a different way