Page MenuHomePhabricator

Add a diagnostic for PS4 pragma comment
AbandonedPublic

Authored by ygao on Mar 18 2015, 6:27 PM.

Details

Reviewers
None
Summary

Hi,
PS4 target recognizes the #pragma comment() syntax as in -fms-extensions, but only handles the
case of #pragma comment(lib). This patch adds a warning if any other arguments are encountered.

This patch also refactors the code in ParsePragma.cpp a little bit to make it more obvious that some
codes are being shared between -fms-extensions and PS4 target.

Could someone kindly take a look at the patch?

  • Gao

Diff Detail

Event Timeline

ygao updated this revision to Diff 22237.Mar 18 2015, 6:27 PM
ygao retitled this revision from to Add a diagnostic for PS4 pragma comment.
ygao updated this object.
ygao edited the test plan for this revision. (Show Details)
ygao added a subscriber: Unknown Object (MLST).
ygao abandoned this revision.Mar 23 2015, 2:36 PM

From: aaron.ballman@gmail.com [aaron.ballman@gmail.com]
Sent: Monday, March 23, 2015 1:06 PM
Subject: Re: [PATCH] Add a diagnostic for PS4 pragma comment
Patch LGTM!
~Aaron

Thanks Aaron for reviewing this!
Committed r233015.