diff --git a/mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp b/mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp --- a/mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp +++ b/mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp @@ -212,7 +212,7 @@ // Promote any single iteration loops in the copy nests and collect // load/stores to simplify. SmallVector copyOps; - for (auto nest : copyNests) + for (Operation *nest : copyNests) // With a post order walk, the erasure of loops does not affect // continuation of the walk or the collection of load/store ops. nest->walk([&](Operation *op) { @@ -228,6 +228,6 @@ OwningRewritePatternList patterns; AffineLoadOp::getCanonicalizationPatterns(patterns, &getContext()); AffineStoreOp::getCanonicalizationPatterns(patterns, &getContext()); - for (auto op : copyOps) + for (Operation *op : copyOps) applyOpPatternsAndFold(op, std::move(patterns)); } diff --git a/mlir/lib/Dialect/Affine/Utils/Utils.cpp b/mlir/lib/Dialect/Affine/Utils/Utils.cpp --- a/mlir/lib/Dialect/Affine/Utils/Utils.cpp +++ b/mlir/lib/Dialect/Affine/Utils/Utils.cpp @@ -44,7 +44,7 @@ static Operation *getOutermostInvariantForOp(AffineIfOp ifOp) { // Walk up the parents past all for op that this conditional is invariant on. auto ifOperands = ifOp.getOperands(); - auto res = ifOp.getOperation(); + auto *res = ifOp.getOperation(); while (!isa(res->getParentOp())) { auto *parentOp = res->getParentOp(); if (auto forOp = dyn_cast(parentOp)) { diff --git a/mlir/lib/Transforms/LoopFusion.cpp b/mlir/lib/Transforms/LoopFusion.cpp --- a/mlir/lib/Transforms/LoopFusion.cpp +++ b/mlir/lib/Transforms/LoopFusion.cpp @@ -591,7 +591,7 @@ // dependence. void forEachMemRefEdge(ArrayRef edges, const std::function &callback) { - for (auto &edge : edges) { + for (const auto &edge : edges) { // Skip if 'edge' is not a memref dependence edge. if (!edge.value.getType().isa()) continue; @@ -607,7 +607,7 @@ void print(raw_ostream &os) const { os << "\nMemRefDependenceGraph\n"; os << "\nNodes:\n"; - for (auto &idAndNode : nodes) { + for (const auto &idAndNode : nodes) { os << "Node: " << idAndNode.first << "\n"; auto it = inEdges.find(idAndNode.first); if (it != inEdges.end()) { diff --git a/mlir/lib/Transforms/Utils/LoopFusionUtils.cpp b/mlir/lib/Transforms/Utils/LoopFusionUtils.cpp --- a/mlir/lib/Transforms/Utils/LoopFusionUtils.cpp +++ b/mlir/lib/Transforms/Utils/LoopFusionUtils.cpp @@ -113,7 +113,7 @@ return WalkResult::advance(); } for (auto value : op->getResults()) { - for (auto user : value.getUsers()) { + for (Operation *user : value.getUsers()) { SmallVector loops; // Check if any loop in loop nest surrounding 'user' is 'opB'. getLoopIVs(*user, &loops); diff --git a/mlir/lib/Transforms/Utils/LoopUtils.cpp b/mlir/lib/Transforms/Utils/LoopUtils.cpp --- a/mlir/lib/Transforms/Utils/LoopUtils.cpp +++ b/mlir/lib/Transforms/Utils/LoopUtils.cpp @@ -1245,8 +1245,8 @@ // be formed. static LogicalResult tryIsolateBands(const TileLoops &tileLoops) { LogicalResult status = success(); - auto &interTile = tileLoops.first; - auto &intraTile = tileLoops.second; + const Loops &interTile = tileLoops.first; + const Loops &intraTile = tileLoops.second; auto size = interTile.size(); assert(size == intraTile.size()); if (size <= 1) @@ -2135,7 +2135,7 @@ auto updateRegion = [&](const SmallMapVector, 4> &targetRegions) { - auto it = targetRegions.find(region->memref); + const auto it = targetRegions.find(region->memref); if (it == targetRegions.end()) return false;