This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add options to control paired vector memops support
ClosedPublic

Authored by bsaleil on Jul 13 2020, 2:44 PM.

Details

Summary

This patch adds frontend and backend options to enable and disable the PowerPC paired vector memory operations added in ISA 3.1.
Instructions using these options will be added in subsequent patches.

Diff Detail

Event Timeline

bsaleil created this revision.Jul 13 2020, 2:44 PM

Please re-upload this and provide the missing context.

bsaleil updated this revision to Diff 277838.Jul 14 2020, 8:18 AM

Re-upload with surrounding context

bsaleil updated this revision to Diff 277847.Jul 14 2020, 8:47 AM

Add test to check paired-vector-memops is supported by the targets.

amyk added inline comments.Jul 17 2020, 2:38 PM
llvm/lib/Target/PowerPC/PPC.td
240

Is this supposed to be FeatureISA3_1?

llvm/lib/Target/PowerPC/PPCScheduleP9.td
42–43

Add the paired vector mem ops to the comment.

bsaleil updated this revision to Diff 279341.Jul 20 2020, 2:08 PM

Add PairedVectorMemops to the list of unsupported features in a comment

bsaleil marked an inline comment as done.Jul 22 2020, 1:17 PM
bsaleil added inline comments.
llvm/lib/Target/PowerPC/PPC.td
240

We need to keep FeatureISA3_0 to be able to enable MMA (that depends on this feature) with P9 codegen.

amyk accepted this revision as: amyk.Jul 27 2020, 10:22 AM

This LGTM. Thanks for addressing the comments Baptiste.

This revision is now accepted and ready to land.Jul 27 2020, 10:22 AM
bsaleil updated this revision to Diff 281341.Jul 28 2020, 1:20 PM

Update diff so it can be applied to master

This revision was automatically updated to reflect the committed changes.