diff --git a/llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h b/llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h --- a/llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h +++ b/llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h @@ -63,6 +63,8 @@ MCSection *getSectionForJumpTable(const Function &F, const TargetMachine &TM) const override; + MCSection *getSectionForLSDA(const Function &F, + const TargetMachine &TM) const override; MCSection * getSectionForMachineBasicBlock(const Function &F, diff --git a/llvm/include/llvm/MC/MCObjectFileInfo.h b/llvm/include/llvm/MC/MCObjectFileInfo.h --- a/llvm/include/llvm/MC/MCObjectFileInfo.h +++ b/llvm/include/llvm/MC/MCObjectFileInfo.h @@ -250,7 +250,6 @@ MCSection *getDataSection() const { return DataSection; } MCSection *getBSSSection() const { return BSSSection; } MCSection *getReadOnlySection() const { return ReadOnlySection; } - MCSection *getLSDASection() const { return LSDASection; } MCSection *getCompactUnwindSection() const { return CompactUnwindSection; } MCSection *getDwarfAbbrevSection() const { return DwarfAbbrevSection; } MCSection *getDwarfInfoSection() const { return DwarfInfoSection; } diff --git a/llvm/include/llvm/Target/TargetLoweringObjectFile.h b/llvm/include/llvm/Target/TargetLoweringObjectFile.h --- a/llvm/include/llvm/Target/TargetLoweringObjectFile.h +++ b/llvm/include/llvm/Target/TargetLoweringObjectFile.h @@ -118,6 +118,10 @@ virtual MCSection *getSectionForJumpTable(const Function &F, const TargetMachine &TM) const; + virtual MCSection *getSectionForLSDA(const Function &F, + const TargetMachine &TM) const { + return LSDASection; + } virtual bool shouldPutJumpTableInFunctionSection(bool UsesLabelDifference, const Function &F) const; diff --git a/llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp b/llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp --- a/llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp @@ -417,7 +417,8 @@ bool HaveTTData = !TypeInfos.empty() || !FilterIds.empty(); // Type infos. - MCSection *LSDASection = Asm->getObjFileLowering().getLSDASection(); + MCSection *LSDASection = + Asm->getObjFileLowering().getSectionForLSDA(MF->getFunction(), Asm->TM); unsigned TTypeEncoding; if (!HaveTTData) { diff --git a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp --- a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp +++ b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp @@ -833,6 +833,42 @@ /* AssociatedSymbol */ nullptr); } +MCSection * +TargetLoweringObjectFileELF::getSectionForLSDA(const Function &F, + const TargetMachine &TM) const { + // If neither COMDAT nor function sections, use the monolithic LSDA section. + if (!F.hasComdat() && !TM.getFunctionSections()) + return LSDASection; + + const auto *LSDA = cast(LSDASection); + unsigned Flags = LSDA->getFlags(); + StringRef Group; + if (F.hasComdat()) { + Group = F.getComdat()->getName(); + Flags |= ELF::SHF_GROUP; + } + + // We assume that -funique-section-names does not apply to .gcc_except_table + // to save string table space. Allocate a unique ID if function sections && + // (integrated assembler or GNU as>=2.35). Note we could use SHF_LINK_ORDER to + // facilitate --gc-sections but that would require that we know the linker is + // a modern LLD (12.0 or later). GNU ld as of 2.35 does not support mixed + // SHF_LINK_ORDER & non-SHF_LINK_ORDER components in an output section + // https://sourceware.org/bugzilla/show_bug.cgi?id=26256 + // + // With GNU as<2.35 (no unique ID support), append the function name as the + // suffix like GCC. + bool Gas = !getContext().getAsmInfo()->useIntegratedAssembler(); + if (TM.getFunctionSections() && Gas) + return getContext().getELFSection(LSDA->getName() + "." + F.getName(), + LSDA->getType(), Flags, 0, Group, + MCSection::NonUniqueID, nullptr); + unsigned ID = TM.getFunctionSections() && !Gas ? NextUniqueID++ + : MCSection::NonUniqueID; + return getContext().getELFSection(LSDA->getName(), LSDA->getType(), Flags, 0, + Group, ID, nullptr); +} + bool TargetLoweringObjectFileELF::shouldPutJumpTableInFunctionSection( bool UsesLabelDifference, const Function &F) const { // We can always create relative relocations, so use another section diff --git a/llvm/test/CodeGen/X86/gcc_except_table-multi.ll b/llvm/test/CodeGen/X86/gcc_except_table-multi.ll new file mode 100644 --- /dev/null +++ b/llvm/test/CodeGen/X86/gcc_except_table-multi.ll @@ -0,0 +1,56 @@ +; RUN: llc < %s -mtriple=x86_64 | FileCheck %s --check-prefixes=CHECK,NOSEP +; RUN: llc < %s -mtriple=x86_64 -function-sections | FileCheck %s --check-prefixes=CHECK,SEP + +;; Don't use `,unique` if GNU as<2.35. +; RUN: llc < %s -mtriple=x86_64 -no-integrated-as | FileCheck %s --check-prefixes=CHECK,NOSEP_GAS +; RUN: llc < %s -mtriple=x86_64 -function-sections -no-integrated-as | FileCheck %s --check-prefixes=CHECK,SEP_GAS + +@_ZTIi = external constant i8* + +;; If the function is in a comdat group, the generated .gcc_except_table should +;; be placed in the same group, so that .gcc_except_table can be discarded if +;; the comdat is not prevailing. If -ffunction-sections, use ,unique to make +;; sections within the same comdat group separate. With GNU as<2.35, append the +;; function name. +$group = comdat any +define i32 @group() uwtable comdat personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) { +; CHECK-LABEL: group: +; CHECK: .cfi_endproc +; NOSEP-NEXT: .section .gcc_except_table,"aG",@progbits,group,comdat{{$}} +; SEP-NEXT: .section .gcc_except_table,"aG",@progbits,group,comdat,unique,1 +; NOSEP_GAS-NEXT: .section .gcc_except_table,"aG",@progbits,group,comdat{{$}} +; SEP_GAS-NEXT: .section .gcc_except_table.group,"aG",@progbits,group,comdat{{$}} +entry: + invoke void @ext() to label %try.cont unwind label %lpad +lpad: + %0 = landingpad { i8*, i32 } catch i8* bitcast (i8** @_ZTIi to i8*) + br label %eh.resume +try.cont: + ret i32 0 +eh.resume: + resume { i8*, i32 } %0 +} + +;; If the function is not in a comdat group but function sections is enabled, +;; use `,unique` or append the function name. +define i32 @foo() uwtable personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) { +; CHECK-LABEL: foo: +; CHECK: .cfi_endproc +; NOSEP-NEXT: .section .gcc_except_table,"a",@progbits{{$}} +; SEP-NEXT: .section .gcc_except_table,"a",@progbits,unique,2 +; NOSEP_GAS-NEXT: .section .gcc_except_table,"a",@progbits{{$}} +; SEP_GAS-NEXT: .section .gcc_except_table.foo,"a",@progbits{{$}} +entry: + invoke void @ext() to label %try.cont unwind label %lpad +lpad: + %0 = landingpad { i8*, i32 } catch i8* bitcast (i8** @_ZTIi to i8*) + br label %eh.resume +try.cont: + ret i32 0 +eh.resume: + resume { i8*, i32 } %0 +} + +declare void @ext() + +declare i32 @__gxx_personality_v0(...)