Page MenuHomePhabricator

libc++: don't attempt to validate the output of %p
ClosedPublic

Authored by ed on Mar 16 2015, 2:37 AM.

Details

Summary

In one of the ostream tests we attempt to validate whether the output of %p is correct. This is actually outside the scope of libc++, for the reason that the format of %p is implementation defined. Change the test to validate that the output of %p is non-empty and is different when given two unequal addresses.

Diff Detail

Repository
rL LLVM

Event Timeline

ed updated this revision to Diff 22015.Mar 16 2015, 2:37 AM
ed retitled this revision from to libc++: don't attempt to validate the output of %p.
ed updated this object.
ed edited the test plan for this revision. (Show Details)
ed added reviewers: EricWF, mclow.lists.
ed set the repository for this revision to rL LLVM.
ed added a subscriber: Unknown Object (MLST).
mclow.lists accepted this revision.Mar 16 2015, 10:49 AM
mclow.lists edited edge metadata.

I'm OK with this.

This revision is now accepted and ready to land.Mar 16 2015, 10:49 AM
This revision was automatically updated to reflect the committed changes.