This is an archive of the discontinued LLVM Phabricator instance.

Differential D83130

[OPENMP]Fix test for ARM, NFC.
AbandonedPublic

Authored by ABataev on Jul 3 2020, 7:14 AM.

Details

Reviewers
grokos
jdoerfert
Summary

Need to provide additional -fPIC option to be able to run the test on
ARM platform. Reported and confirmed by Itaru Kitayama.

Diff Detail

Event Timeline

ABataev created this revision.Jul 3 2020, 7:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2020, 7:14 AM
Herald added subscribers: openmp-commits, danielkiss, guansong and 2 others. · View Herald Transcript
Harbormaster failed remote builds in B62845: Diff 275390!Jul 3 2020, 8:02 AM
Herald added a subscriber: sstefan1. · View Herald TranscriptJul 3 2020, 8:02 AM
grokos accepted this revision.Jul 6 2020, 10:12 AM

Looks good. Do we know why the test doesn't run without -fPIC?

This revision is now accepted and ready to land.Jul 6 2020, 10:12 AM
ABataev added a comment.Jul 6 2020, 10:15 AM
In D83130#2133492, @grokos wrote:

Looks good. Do we know why the test doesn't run without -fPIC?

Looks like specific behavior for ARM. -shared requires -fPIC

ABataev abandoned this revision.Sep 16 2020, 5:13 AM

Revision Contents

PathSize
openmp/
libomptarget/
test/
offloading/
2 lines

Diff 275390

openmp/libomptarget/test/offloading/dynamic_module_load.c

// RUN: %libomptarget-compile-aarch64-unknown-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-aarch64-unknown-linux-gnu -ldl && %libomptarget-run-aarch64-unknown-linux-gnu %t.so 2>&1 | %fcheck-aarch64-unknown-linux-gnu // RUN: %libomptarget-compile-aarch64-unknown-linux-gnu -DSHARED -shared -fPIC -o %t.so && %clang %flags %s -o %t-aarch64-unknown-linux-gnu -ldl && %libomptarget-run-aarch64-unknown-linux-gnu %t.so 2>&1 | %fcheck-aarch64-unknown-linux-gnu
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-// RUN: %libomptarget-compile-aarch64-unknown-linux-gnu -DSHARED -shared -fPIC -o %t.so && %clang %flags %s -o %t-aarch64-unknown-linux-gnu -ldl && %libomptarget-run-aarch64-unknown-linux-gnu %t.so 2>&1 | %fcheck-aarch64-unknown-linux-gnu
-// RUN: %libomptarget-compile-powerpc64-ibm-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-powerpc64-ibm-linux-gnu -ldl && %libomptarget-run-powerpc64-ibm-linux-gnu %t.so 2>&1 | %fcheck-powerpc64-ibm-linux-gnu
-// RUN: %libomptarget-compile-powerpc64le-ibm-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-powerpc64le-ibm-linux-gnu -ldl && %libomptarget-run-powerpc64le-ibm-linux-gnu %t.so 2>&1 | %fcheck-powerpc64le-ibm-linux-gnu
-// RUN: %libomptarget-compile-x86_64-pc-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-x86_64-pc-linux-gnu -ldl && %libomptarget-run-x86_64-pc-linux-gnu %t.so 2>&1 | %fcheck-x86_64-pc-linux-gnu
+// RUN: %libomptarget-compile-aarch64-unknown-linux-gnu -DSHARED -shared -fPIC
+// -o %t.so && %clang %flags %s -o %t-aarch64-unknown-linux-gnu -ldl &&
+// %libomptarget-run-aarch64-unknown-linux-gnu %t.so 2>&1 |
+// %fcheck-aarch64-unknown-linux-gnu RUN:
+// %libomptarget-compile-powerpc64-ibm-linux-gnu -DSHARED -shared -o %t.so &&
+// %clang %flags %s -o %t-powerpc64-ibm-linux-gnu -ldl &&

10 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` -// RUN: %libomptarget-compile-aarch64-unknown-linux…
// RUN: %libomptarget-compile-powerpc64-ibm-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-powerpc64-ibm-linux-gnu -ldl && %libomptarget-run-powerpc64-ibm-linux-gnu %t.so 2>&1 | %fcheck-powerpc64-ibm-linux-gnu // RUN: %libomptarget-compile-powerpc64-ibm-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-powerpc64-ibm-linux-gnu -ldl && %libomptarget-run-powerpc64-ibm-linux-gnu %t.so 2>&1 | %fcheck-powerpc64-ibm-linux-gnu
// RUN: %libomptarget-compile-powerpc64le-ibm-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-powerpc64le-ibm-linux-gnu -ldl && %libomptarget-run-powerpc64le-ibm-linux-gnu %t.so 2>&1 | %fcheck-powerpc64le-ibm-linux-gnu // RUN: %libomptarget-compile-powerpc64le-ibm-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-powerpc64le-ibm-linux-gnu -ldl && %libomptarget-run-powerpc64le-ibm-linux-gnu %t.so 2>&1 | %fcheck-powerpc64le-ibm-linux-gnu
// RUN: %libomptarget-compile-x86_64-pc-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-x86_64-pc-linux-gnu -ldl && %libomptarget-run-x86_64-pc-linux-gnu %t.so 2>&1 | %fcheck-x86_64-pc-linux-gnu // RUN: %libomptarget-compile-x86_64-pc-linux-gnu -DSHARED -shared -o %t.so && %clang %flags %s -o %t-x86_64-pc-linux-gnu -ldl && %libomptarget-run-x86_64-pc-linux-gnu %t.so 2>&1 | %fcheck-x86_64-pc-linux-gnu
#ifdef SHARED #ifdef SHARED
#include <stdio.h> #include <stdio.h>
int foo() { int foo() {
#pragma omp target #pragma omp target
Show All 25 Lines