Page MenuHomePhabricator

WIP: Use SB APIs in CommandObjects
Needs ReviewPublic

Authored by shivammittal99 on Jun 28 2020, 3:45 PM.

Details

Summary

Signed-off-by: Shivam Mittal <shivammittal99@gmail.com>

Diff Detail

Event Timeline

shivammittal99 created this revision.Jun 28 2020, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2020, 3:45 PM
  • Extend SBTarget to enable/disable/ignore watchpoints

Given that the SB API is stable I wonder if we should be proactive and have these new functions return SBError instead of a bool so that they can be extended if we ever to decide to return a useful error.

@JDevlieghere Sounds good! I'll make the changes and use that for any future additions.

teemperor added inline comments.Jul 8 2020, 2:34 AM
lldb/include/lldb/API/SBBreakpoint.h
142

I assume this is WIP code and we already told you that, but we can't expose the internal lldb_private::* classes (or their lldb::*SP typedef). So this needs to be replaced with SB API patches.

lldb/include/lldb/API/SBTarget.h
69

This should rather be a IsAlive function in SBProcess.

teemperor resigned from this revision.Mar 25 2021, 3:56 AM