This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][Tool] Fix install directory of ompt-multiplex.h
AbandonedPublic

Authored by protze.joachim on Jun 19 2020, 12:43 AM.

Details

Summary

As raised in https://reviews.llvm.org/D76012, the header is currently installed to $CMAKE_INSTALL_PREFIX/include.
This patch changes the install destination to install next to the other OpenMP headers.

Diff Detail

Event Timeline

LIBOMP_HEADERS_INSTALL_PATH is the internal compiler where for example omp.h. I think the header tool is of relevance outside of Clang, so IMO it should go the general include/ directory.

With the same argument, omp-tools.h should not go to ${CMAKE_INSTALL_PREFIX}/lib/clang/11.0.0/include/omp-tools.h, but ${CMAKE_INSTALL_PREFIX}/include.
Other than omp.h, the header is not used for code compiled with -fopenmp flag.

protze.joachim abandoned this revision.Jul 17 2020, 1:45 PM