diff --git a/mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp b/mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp --- a/mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp +++ b/mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp @@ -25,6 +25,19 @@ using namespace mlir; //===----------------------------------------------------------------------===// +// Utility functions +//===----------------------------------------------------------------------===// + +/// Returns true if the given type is an unsigned integer or vector type +static bool isUnsignedIntegerOrVector(Type type) { + if (type.isUnsignedInteger()) + return true; + if (auto vecType = type.dyn_cast()) + return vecType.getElementType().isUnsignedInteger(); + return false; +} + +//===----------------------------------------------------------------------===// // Operation conversion //===----------------------------------------------------------------------===// @@ -91,6 +104,48 @@ return success(); } }; + +/// Converts SPIR-V shift ops to LLVM shift ops. Since LLVM dialect +/// puts a restriction on `Shift` and `Base` to have the same bit width, +/// `Shift` is zero or sign extended to match this specification. Cases when +/// `Shift` bit width > `Base` bit width are considered to be illegal. +template +class ShiftPattern : public SPIRVToLLVMConversion { +public: + using SPIRVToLLVMConversion::SPIRVToLLVMConversion; + + LogicalResult + matchAndRewrite(SPIRVOp operation, ArrayRef operands, + ConversionPatternRewriter &rewriter) const override { + + auto dstType = this->typeConverter.convertType(operation.getType()); + if (!dstType) + return failure(); + + Type op1Type = operation.operand1().getType(); + Type op2Type = operation.operand2().getType(); + + if (op1Type == op2Type) { + rewriter.template replaceOpWithNewOp(operation, dstType, + operands); + return success(); + } + + Location loc = operation.getLoc(); + Value extended; + if (isUnsignedIntegerOrVector(op2Type)) { + extended = rewriter.template create(loc, dstType, + operation.operand2()); + } else { + extended = rewriter.template create(loc, dstType, + operation.operand2()); + } + Value result = rewriter.template create( + loc, dstType, operation.operand1(), extended); + rewriter.replaceOp(operation, result); + return success(); + } +}; } // namespace //===----------------------------------------------------------------------===// @@ -142,6 +197,11 @@ IComparePattern, IComparePattern, IComparePattern, - IComparePattern>( - context, typeConverter); + IComparePattern, + + // Shift ops + ShiftPattern, + ShiftPattern, + ShiftPattern>(context, + typeConverter); } diff --git a/mlir/test/Conversion/SPIRVToLLVM/shifts-to-llvm.mlir b/mlir/test/Conversion/SPIRVToLLVM/shifts-to-llvm.mlir new file mode 100644 --- /dev/null +++ b/mlir/test/Conversion/SPIRVToLLVM/shifts-to-llvm.mlir @@ -0,0 +1,115 @@ +// RUN: mlir-opt -convert-spirv-to-llvm %s | FileCheck %s + +//===----------------------------------------------------------------------===// +// spv.ShiftRightArithmetic +//===----------------------------------------------------------------------===// + +func @shift_right_arithmetic_scalar(%arg0: i32, %arg1: si32, %arg2 : i16, %arg3 : ui16) { + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %{{.*}} : !llvm.i32 + %0 = spv.ShiftRightArithmetic %arg0, %arg0 : i32, i32 + + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %{{.*}} : !llvm.i32 + %1 = spv.ShiftRightArithmetic %arg0, %arg1 : i32, si32 + + // CHECK: %[[EXT1:.*]] = llvm.sext %{{.*}} : !llvm.i16 to !llvm.i32 + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %[[EXT1:.*]]: !llvm.i32 + %2 = spv.ShiftRightArithmetic %arg0, %arg2 : i32, i16 + + // CHECK: %[[EXT2:.*]] = llvm.zext %{{.*}} : !llvm.i16 to !llvm.i32 + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %[[EXT2:.*]]: !llvm.i32 + %3 = spv.ShiftRightArithmetic %arg0, %arg3 : i32, ui16 + return +} + +func @shift_right_arithmetic_vector(%arg0: vector<4xi64>, %arg1: vector<4xui64>, %arg2: vector<4xi32>, %arg3: vector<4xui32>) { + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %{{.*}} : !llvm<"<4 x i64>"> + %0 = spv.ShiftRightArithmetic %arg0, %arg0 : vector<4xi64>, vector<4xi64> + + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %{{.*}} : !llvm<"<4 x i64>"> + %1 = spv.ShiftRightArithmetic %arg0, %arg1 : vector<4xi64>, vector<4xui64> + + // CHECK: %[[EXT1:.*]] = llvm.sext %{{.*}} : !llvm<"<4 x i32>"> to !llvm<"<4 x i64>"> + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %[[EXT1:.*]]: !llvm<"<4 x i64>"> + %2 = spv.ShiftRightArithmetic %arg0, %arg2 : vector<4xi64>, vector<4xi32> + + // CHECK: %[[EXT2:.*]] = llvm.zext %{{.*}} : !llvm<"<4 x i32>"> to !llvm<"<4 x i64>"> + // CHECK: %{{.*}} = llvm.ashr %{{.*}}, %[[EXT2:.*]]: !llvm<"<4 x i64>"> + %3 = spv.ShiftRightArithmetic %arg0, %arg3 : vector<4xi64>, vector<4xui32> + return +} + +//===----------------------------------------------------------------------===// +// spv.ShiftRightLogical +//===----------------------------------------------------------------------===// + +func @shift_right_logical_scalar(%arg0: i32, %arg1: si32, %arg2 : si16, %arg3 : ui16) { + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %{{.*}} : !llvm.i32 + %0 = spv.ShiftRightLogical %arg0, %arg0 : i32, i32 + + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %{{.*}} : !llvm.i32 + %1 = spv.ShiftRightLogical %arg0, %arg1 : i32, si32 + + // CHECK: %[[EXT1:.*]] = llvm.sext %{{.*}} : !llvm.i16 to !llvm.i32 + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %[[EXT1:.*]]: !llvm.i32 + %2 = spv.ShiftRightLogical %arg0, %arg2 : i32, si16 + + // CHECK: %[[EXT2:.*]] = llvm.zext %{{.*}} : !llvm.i16 to !llvm.i32 + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %[[EXT2:.*]]: !llvm.i32 + %3 = spv.ShiftRightLogical %arg0, %arg3 : i32, ui16 + return +} + +func @shift_right_logical_vector(%arg0: vector<4xi64>, %arg1: vector<4xsi64>, %arg2: vector<4xi32>, %arg3: vector<4xui32>) { + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %{{.*}} : !llvm<"<4 x i64>"> + %0 = spv.ShiftRightLogical %arg0, %arg0 : vector<4xi64>, vector<4xi64> + + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %{{.*}} : !llvm<"<4 x i64>"> + %1 = spv.ShiftRightLogical %arg0, %arg1 : vector<4xi64>, vector<4xsi64> + + // CHECK: %[[EXT1:.*]] = llvm.sext %{{.*}} : !llvm<"<4 x i32>"> to !llvm<"<4 x i64>"> + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %[[EXT1:.*]]: !llvm<"<4 x i64>"> + %2 = spv.ShiftRightLogical %arg0, %arg2 : vector<4xi64>, vector<4xi32> + + // CHECK: %[[EXT2:.*]] = llvm.zext %{{.*}} : !llvm<"<4 x i32>"> to !llvm<"<4 x i64>"> + // CHECK: %{{.*}} = llvm.lshr %{{.*}}, %[[EXT2:.*]]: !llvm<"<4 x i64>"> + %3 = spv.ShiftRightLogical %arg0, %arg3 : vector<4xi64>, vector<4xui32> + return +} + +//===----------------------------------------------------------------------===// +// spv.ShiftLeftLogical +//===----------------------------------------------------------------------===// + +func @shift_left_logical_scalar(%arg0: i32, %arg1: si32, %arg2 : i16, %arg3 : ui16) { + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %{{.*}} : !llvm.i32 + %0 = spv.ShiftLeftLogical %arg0, %arg0 : i32, i32 + + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %{{.*}} : !llvm.i32 + %1 = spv.ShiftLeftLogical %arg0, %arg1 : i32, si32 + + // CHECK: %[[EXT1:.*]] = llvm.sext %{{.*}} : !llvm.i16 to !llvm.i32 + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %[[EXT1:.*]]: !llvm.i32 + %2 = spv.ShiftLeftLogical %arg0, %arg2 : i32, i16 + + // CHECK: %[[EXT2:.*]] = llvm.zext %{{.*}} : !llvm.i16 to !llvm.i32 + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %[[EXT2:.*]]: !llvm.i32 + %3 = spv.ShiftLeftLogical %arg0, %arg3 : i32, ui16 + return +} + +func @shift_left_logical_vector(%arg0: vector<4xi64>, %arg1: vector<4xsi64>, %arg2: vector<4xi32>, %arg3: vector<4xui32>) { + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %{{.*}} : !llvm<"<4 x i64>"> + %0 = spv.ShiftLeftLogical %arg0, %arg0 : vector<4xi64>, vector<4xi64> + + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %{{.*}} : !llvm<"<4 x i64>"> + %1 = spv.ShiftLeftLogical %arg0, %arg1 : vector<4xi64>, vector<4xsi64> + + // CHECK: %[[EXT1:.*]] = llvm.sext %{{.*}} : !llvm<"<4 x i32>"> to !llvm<"<4 x i64>"> + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %[[EXT1:.*]]: !llvm<"<4 x i64>"> + %2 = spv.ShiftLeftLogical %arg0, %arg2 : vector<4xi64>, vector<4xi32> + + // CHECK: %[[EXT2:.*]] = llvm.zext %{{.*}} : !llvm<"<4 x i32>"> to !llvm<"<4 x i64>"> + // CHECK: %{{.*}} = llvm.shl %{{.*}}, %[[EXT2:.*]]: !llvm<"<4 x i64>"> + %3 = spv.ShiftLeftLogical %arg0, %arg3 : vector<4xi64>, vector<4xui32> + return +}