Page MenuHomePhabricator

Refactor: Simplify boolean expressions
ClosedPublic

Authored by LegalizeAdulthood on Mar 8 2015, 4:31 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean expressions.
LegalizeAdulthood updated this object.
LegalizeAdulthood edited the test plan for this revision. (Show Details)
LegalizeAdulthood added subscribers: Unknown Object (MLST), Unknown Object (MLST).
dblaikie accepted this revision.Mar 8 2015, 4:41 PM
dblaikie added a reviewer: dblaikie.
dblaikie added a subscriber: dblaikie.

Looks good to me - please commit. One or two optional comments.

lib/IR/InlineAsm.cpp
78 ↗(On Diff #21461)

could drop the parens here (before/after/at the same time/not at all)

lib/MC/MCParser/DarwinAsmParser.cpp
629 ↗(On Diff #21461)

aside: I wonder if this (& the previous function, getGenDwarfForAsembly) should be 'is' rather than 'get'

This revision is now accepted and ready to land.Mar 8 2015, 4:41 PM
lib/IR/InlineAsm.cpp
78 ↗(On Diff #21461)

Fixed

lib/MC/MCParser/DarwinAsmParser.cpp
629 ↗(On Diff #21461)

I'll leave that for someone else to decide :-).

LegalizeAdulthood edited edge metadata.

Remove unnecessary parenthesis

If this is acceptable, would someone commit this for me please? Thanks.

If this is acceptable, would someone commit this for me please? Thanks.

Sure - committed in r231617

This revision was automatically updated to reflect the committed changes.