diff --git a/clang/unittests/StaticAnalyzer/ParamRegionTest.cpp b/clang/unittests/StaticAnalyzer/ParamRegionTest.cpp --- a/clang/unittests/StaticAnalyzer/ParamRegionTest.cpp +++ b/clang/unittests/StaticAnalyzer/ParamRegionTest.cpp @@ -20,8 +20,8 @@ const StackFrameContext *SFC, const ParmVarDecl *PVD) { for (const auto *D2: PVD->redecls()) { - const auto *PVD2 = cast(D2); - assert(MRMgr.getVarRegion(PVD, SFC) == MRMgr.getVarRegion(PVD2, SFC)); + assert(MRMgr.getVarRegion(PVD, SFC) == + MRMgr.getVarRegion(cast(D2), SFC)); } } @@ -33,29 +33,26 @@ if (const auto *FD = dyn_cast(D)) { for (const auto *P : FD->parameters()) { - const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC); if (SFC->inTopFrame()) - assert(isa(Reg)); + assert(isa(MRMgr.getVarRegion(P, SFC))); else - assert(isa(Reg)); + assert(isa(MRMgr.getVarRegion(P, SFC))); checkForSameParamRegions(MRMgr, SFC, P); } } else if (const auto *CD = dyn_cast(D)) { for (const auto *P : CD->parameters()) { - const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC); if (SFC->inTopFrame()) - assert(isa(Reg)); + assert(isa(MRMgr.getVarRegion(P, SFC))); else - assert(isa(Reg)); + assert(isa(MRMgr.getVarRegion(P, SFC))); checkForSameParamRegions(MRMgr, SFC, P); } } else if (const auto *MD = dyn_cast(D)) { for (const auto *P : MD->parameters()) { - const TypedValueRegion *Reg = MRMgr.getVarRegion(P, SFC); if (SFC->inTopFrame()) - assert(isa(Reg)); + assert(isa(MRMgr.getVarRegion(P, SFC))); else - assert(isa(Reg)); + assert(isa(MRMgr.getVarRegion(P, SFC))); checkForSameParamRegions(MRMgr, SFC, P); } }