Page MenuHomePhabricator

1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage
ClosedPublic

Authored by jankratochvil on Jun 8 2020, 12:52 PM.

Details

Summary

There is Labath's comment which is more tricky than it looks. So first cleanup the code a bit.

Event Timeline

labath accepted this revision.Jun 9 2020, 12:49 AM
labath added inline comments.
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
733 ↗(On Diff #269326)

I guess this could keep calling the public version of this function without the extra argument.

783 ↗(On Diff #269326)

and this too(?)

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
182 ↗(On Diff #269326)

That comment is probably not useful anymore.

This revision is now accepted and ready to land.Jun 9 2020, 12:49 AM
jankratochvil marked 4 inline comments as done.Jun 9 2020, 4:46 AM
jankratochvil added inline comments.
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
733 ↗(On Diff #269326)

It was intentional but in fact you are right.

This revision was automatically updated to reflect the committed changes.
jankratochvil marked an inline comment as done.