[libcxx] Fix LWG 2875: shared_ptr::shared_ptr(Y*, D, […]) constructors should be constrained.
Needs ReviewPublic
Actions

Authored by zoecarver on Jun 8 2020, 11:21 AM.

Details

Reviewers

ldionne

Group Reviewers

Restricted Project

Summary

Fixes LWG issue 2875.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

zoecarver created this revision.Jun 8 2020, 11:21 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2020, 11:21 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added subscribers: libcxx-commits, dexonsmith. · View Herald Transcript

Harbormaster failed remote builds in B59515: Diff 269297!Jun 8 2020, 12:08 PM

Do we have tests that shared_ptr isn't constructible from incompatible array types? If not, could we add some?

Otherwise, mostly LGTM.

libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp
71	Nit: Please don't wrap here.

This revision now requires changes to proceed.Jun 9 2020, 8:13 AM

Fix line wrapping

Do we have tests that shared_ptr isn't constructible from incompatible array types? If not, could we add some?

The __compatible_with trait removes the array extent. And (AFAIK) there are no array types that are convertible where their elements aren't. I'll make another patch to add tests that ensure we *can* construct a shared_ptr with array types that aren't convertible but where their elements are.

zoecarver mentioned this in D81532: [libcxx] Add compatible with constraint tests for some shared_ptr constructors..Jun 9 2020, 9:59 PM

Harbormaster failed remote builds in B59735: Diff 269731!Jun 9 2020, 11:06 PM

zoecarver mentioned this in D62274: shared_ptr deleter requirements (2802).Jun 10 2020, 12:16 PM

zoecarver mentioned this in rG8697d6cfa894: [libcxx] Add compatible with constraint tests for some shared_ptr constructors..Aug 1 2020, 12:07 PM