Page MenuHomePhabricator

[DAGCombiner] Add a shuffle mask commutation helper function.
ClosedPublic

Authored by RKSimon on Mar 7 2015, 1:00 PM.

Details

Summary

We have an increasing number of cases where we are creating commuted shuffle masks - all implementing nearly the same code.

This patch adds a static helper function - ShuffleVectorSDNode::commuteMask() and replaces a number of cases to use it. If people know of other cases that could use it as well please comment and I will add them to the patch.

NFCI

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon updated this revision to Diff 21431.Mar 7 2015, 1:00 PM
RKSimon retitled this revision from to [DAGCombiner] Add a shuffle mask commutation helper function..
RKSimon updated this object.
RKSimon edited the test plan for this revision. (Show Details)
RKSimon added reviewers: andreadb, mkuper, chandlerc.
RKSimon set the repository for this revision to rL LLVM.
RKSimon added a subscriber: Unknown Object (MLST).
andreadb accepted this revision.Mar 7 2015, 1:25 PM
andreadb edited edge metadata.

Hi Simon,

The patch LGTM.

Thanks!
-Andrea

This revision is now accepted and ready to land.Mar 7 2015, 1:25 PM
This revision was automatically updated to reflect the committed changes.

Thanks Andrea