diff --git a/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp b/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp --- a/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp +++ b/llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp @@ -1287,7 +1287,23 @@ LLVM_DEBUG(dbgs() << " Operand not killed at " << FirstMI << "\n"); return false; } - auto canRenameMOP = [](const MachineOperand &MOP) { + auto canRenameMOP = [TRI](const MachineOperand &MOP) { + if (MOP.isReg()) { + auto *RegClass = TRI->getMinimalPhysRegClass(MOP.getReg()); + // Renaming registers with multiple disjunct sub-registers (e.g. the + // result of a LD3) means that all sub-registers are renamed, potentially + // impacting other instructions we did not check. Bail out. + // Note that this relies on the structure of the AArch64 register file. In + // particular, a subregister cannot be written without overwriting the + // whole register. + if (RegClass->HasDisjunctSubRegs) { + LLVM_DEBUG( + dbgs() + << " Cannot rename operands with multiple disjunct subregisters (" + << MOP << ")\n"); + return false; + } + } return MOP.isImplicit() || (MOP.isRenamable() && !MOP.isEarlyClobber() && !MOP.isTied()); }; diff --git a/llvm/test/CodeGen/AArch64/stp-opt-with-renaming-ld3.mir b/llvm/test/CodeGen/AArch64/stp-opt-with-renaming-ld3.mir --- a/llvm/test/CodeGen/AArch64/stp-opt-with-renaming-ld3.mir +++ b/llvm/test/CodeGen/AArch64/stp-opt-with-renaming-ld3.mir @@ -1,5 +1,4 @@ -# XFAIL: * -# RUN: llc -run-pass=aarch64-ldst-opt -mtriple=arm64-apple-iphoneos -aarch64-load-store-renaming=true -verify-machineinstrs -o - %s | FileCheck %s +# RUN: llc -run-pass=aarch64-ldst-opt -mtriple=arm64-apple-iphoneos -aarch64-load-store-renaming=true -o - -verify-machineinstrs %s | FileCheck %s --- | define void @test_ld3(<8 x i8>* %a1) { entry: @@ -11,11 +10,12 @@ --- # CHECK-LABEL: name: test_ld3 # CHECK: bb.0.entry: -# CHECK: renamable $x0, $d1_d2_d3 = LD3Threev8b_POST killed renamable $x0, $xzr +# CHECK: renamable $x0, renamable $d0_d1_d2 = LD3Threev8b_POST killed renamable $x0, $xzr # CHECK-NEXT: STPDi renamable $d0, renamable $d1, $fp, -6 :: (store 8) +# CHECK-NEXT: STURDi renamable $d2, $fp, -32, implicit killed $d0_d1_d2 :: (store 8 into %ir.s1) # CHECK-NEXT: renamable $d0_d1_d2 = LD3Threev8b killed renamable $x0 :: (load 24 from %ir.a1, align 32) -# CHECK-NEXT: STPDi $d3, renamable $d0, $fp, -4 :: (store 8 into %ir.s1), (store 8) -# CHECK-NEXT: STPDi renamable $d1, renamable $d2, $fp, -2 :: (store 8) +# CHECK-NEXT: STPDi renamable $d0, renamable $d1, $fp, -3 :: (store 8) +# CHECK-NEXT: STURDi renamable $d2, $fp, -8, implicit killed $d0_d1_d2 :: (store 8) # CHECK-NEXT: RET undef $lr # name: test_ld3