Page MenuHomePhabricator

[libc++] Remove the c++98 Lit feature from the test suite
ClosedPublic

Authored by ldionne on Jun 1 2020, 7:48 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Restricted Project
Commits
rG31cbe0f240f6: [libc++] Remove the c++98 Lit feature from the test suite
Summary

C++98 and C++03 are effectively aliases as far as Clang is concerned.
As such, allowing both std=c++98 and std=c++03 as Lit parameters is
just slightly confusing, but provides no value. It's similar to allowing
both std=c++17 and std=c++1z, which we don't do.

This was discovered because we had an internal bot that ran the test
suite under both c++98 AND c++03 -- one of which is redundant.

Diff Detail

Event Timeline

ldionne created this revision.Jun 1 2020, 7:48 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 1 2020, 7:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision as: Restricted Project, Restricted Project.Jun 3 2020, 6:36 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2020, 7:06 AM
This revision was automatically updated to reflect the committed changes.