Page MenuHomePhabricator

[libcxx] adds spaceship for vector
Needs ReviewPublic

Authored by cjdb on May 31 2020, 5:34 PM.

Details

Reviewers
EricWF
mclow.lists
ldionne
jfb
BRevzin
Group Reviewers
Restricted Project
Summary

[libcxx] adds spaceship for vector

  • adds C++20 operator== for vector
  • adds operator<=> for vector

Note: This is currently WIP due to being unable to find tests for vector's comparison operations.

Diff Detail

Event Timeline

cjdb created this revision.May 31 2020, 5:34 PM
miscco added a subscriber: miscco.May 31 2020, 11:37 PM
miscco added inline comments.
libcxx/include/compare
679

This is usually spelled as ifndef _LIBCPP_HAS_NO_SPACESHIP_OPERATOR

686

I have to look it up but what about string orderings here?

libcxx/include/vector
3339

Same here #ifndef _LIBCPP_HAS_NO_SPACESHIP_OPERATOR

cjdb added inline comments.Jun 1 2020, 9:11 AM
miscco added inline comments.Jun 1 2020, 10:28 AM
libcxx/include/compare
686

Thanks a lot, I thought I read it in some blog, but that is way better

ldionne added a reviewer: Restricted Project.Nov 2 2020, 2:23 PM