diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -8304,8 +8304,21 @@ } FullExpr = CorrectDelayedTyposInExpr(FullExpr.get()); - if (FullExpr.isInvalid()) - return ExprError(); + if (FullExpr.isInvalid()) { + // Typo-correction fails, we rebuild the broken AST with the typos degraded + // to RecoveryExpr. + // FIXME: we lose source locations for RecoveryExpr, as TypoExpr doesn't + // track source locations. + struct TyposReplace : TreeTransform { + TyposReplace(Sema &SemaRef) : TreeTransform(SemaRef) {} + ExprResult TransformTypoExpr(TypoExpr *E) { + return this->SemaRef.CreateRecoveryExpr(E->getBeginLoc(), + E->getEndLoc(), {}); + } + } TT(*this); + + return TT.TransformExpr(FE); + } CheckCompletedExpr(FullExpr.get(), CC, IsConstexpr); diff --git a/clang/test/AST/ast-dump-recovery.cpp b/clang/test/AST/ast-dump-recovery.cpp --- a/clang/test/AST/ast-dump-recovery.cpp +++ b/clang/test/AST/ast-dump-recovery.cpp @@ -10,6 +10,25 @@ // CHECK-NEXT: `-IntegerLiteral {{.*}} 123 // DISABLED-NOT: -RecoveryExpr {{.*}} contains-errors int invalid_call = some_func(123); +void test_invalid_call(int s) { + // CHECK: CallExpr {{.*}} '' contains-errors + // CHECK-NEXT: |-UnresolvedLookupExpr {{.*}} 'some_func' + // CHECK-NEXT: |-RecoveryExpr {{.*}} <> + // CHECK-NEXT: `-BinaryOperator {{.*}} <, col:28> + // CHECK-NEXT: |-RecoveryExpr {{.*}} <> + // CHECK-NEXT: `-IntegerLiteral {{.*}} 'int' 1 + some_func(undef1, undef2+1); + + // CHECK: BinaryOperator {{.*}} '' contains-errors '=' + // CHECK-NEXT: |-DeclRefExpr {{.*}} 's' + // CHECK-NEXT: `-CallExpr {{.*}} '' contains-errors + // CHECK-NEXT: |-UnresolvedLookupExpr {{.*}} 'some_func' + // CHECK-NEXT: `-RecoveryExpr {{.*}} contains-errors + s = some_func(undef1); + // CHECK: `-VarDecl {{.*}} invalid var 'int' + // FIXME: preserve the broken call. + int var = some_func(undef1); +} int ambig_func(double); int ambig_func(float);