This is an archive of the discontinued LLVM Phabricator instance.

[SVE] Remove usages of VectorType::getNumElements() from ARM
ClosedPublic

Authored by ctetreau on May 12 2020, 3:26 PM.

Diff Detail

Event Timeline

ctetreau created this revision.May 12 2020, 3:26 PM
fpetrogalli added inline comments.May 13 2020, 6:38 AM
llvm/lib/Target/ARM/MVETailPredication.cpp
348

The RHS is not something along the lines of VectorType::get(), or an explicit cast. Please consider reverting it.

dmgreen accepted this revision.May 13 2020, 6:44 AM

Sounds good to me. +1 to @fpetrogalli's comment.

This revision is now accepted and ready to land.May 13 2020, 6:44 AM
ctetreau updated this revision to Diff 264066.May 14 2020, 12:51 PM

address code review issues

ctetreau updated this revision to Diff 264310.May 15 2020, 12:27 PM

Fix whatever happened at the top of MVETailPredication, use the correct vector type at the bottom

ctetreau updated this revision to Diff 264312.May 15 2020, 12:30 PM

fix file header

This revision was automatically updated to reflect the committed changes.