Page MenuHomePhabricator

fix X86Disassembler Address parameter
AbandonedPublic

Authored by vtjnash on Feb 28 2015, 3:24 PM.

Details

Reviewers
None
Summary

Commit r221751 seems to have also caused the Address parameter to llvm::MCDisassembler::getInstruction to be ignored in the final address computation, since it gets both added and then subtracted as an offset. This diff removes this extra indirection so that the Address parameter works as it did in LLVM3.5 and previous.

Diff Detail

Event Timeline

vtjnash updated this revision to Diff 20939.Feb 28 2015, 3:24 PM
vtjnash retitled this revision from to fix X86Disassembler.
vtjnash updated this object.
vtjnash edited the test plan for this revision. (Show Details)
vtjnash set the repository for this revision to rL LLVM.
vtjnash retitled this revision from fix X86Disassembler to fix X86Disassembler Address parameter.
vtjnash added a subscriber: Unknown Object (MLST).Feb 28 2015, 4:26 PM

it looks like the other disassembler targets also ignore Address and simply read the first N bytes from "Bytes", so i assume that was an intentional change in llvm3.5?

vtjnash abandoned this revision.Mar 22 2019, 6:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2019, 6:26 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript