Page MenuHomePhabricator

[compiler-rt] Add a symbolizer testcase for closed stdin/stdout
ClosedPublic

Authored by kubamracek on Feb 28 2015, 3:37 AM.

Details

Reviewers
samsonov
Summary

This testcase just tests that the external symbolizer (llvm-symbolizer) can start and communicate correctly even when the program closed its stdin, stdout and stderr.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 20934.Feb 28 2015, 3:37 AM
kubamracek retitled this revision from to [compiler-rt] Add a symbolizer testcase for closed stdin/stdout.
kubamracek updated this object.
kubamracek edited the test plan for this revision. (Show Details)
kubamracek added subscribers: Unknown Object (MLST), zaks.anna, samsonov.

Good idea

test/asan/TestCases/closed-fds.cc
19

Maybe, we should instead check fprintf return value?

26

Interleave CHECK lines with code...

31

to make this block actually close to the //BOOM line

kubamracek updated this revision to Diff 21299.Mar 5 2015, 12:22 PM

Addressing review comments.

samsonov accepted this revision.Mar 5 2015, 1:36 PM
samsonov added a reviewer: samsonov.

LGTM

test/asan/TestCases/closed-fds.cc
18

CHECK-OUTPUT doesn't seem to be needed here at all.

This revision is now accepted and ready to land.Mar 5 2015, 1:36 PM
kubamracek closed this revision.Mar 5 2015, 3:44 PM

Committed r231429.