This is an archive of the discontinued LLVM Phabricator instance.

[compile-rt] Move stripping of signature from fault address to GetAddress()
ClosedPublic

Authored by yln on May 11 2020, 10:01 AM.

Details

Summary

With the new header which takes care of the ptrauth #ifdef'ing, we can
now move the stripping of the ptrauth signature to it's natural place:
SignalContext::GetAddress() which is defined in the (non-Darwin
specific) file sanitizer_posix.cpp.

Diff Detail

Event Timeline

yln created this revision.May 11 2020, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2020, 10:01 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.May 11 2020, 12:48 PM
vitalybuka added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_posix.cpp
292

this one is confusing without looking into the header
In followup patch, can you please replace ptrauth_strip with inline function internal_ptrauth_strip or SANITIZER_PTRAUTH_STRIP() macro?

This revision is now accepted and ready to land.May 11 2020, 12:48 PM
yln closed this revision.Dec 15 2021, 2:10 PM