diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -860,7 +860,7 @@ def warn_pragma_pop_failed : Warning<"#pragma %0(pop, ...) failed: %1">, InGroup; def err_pragma_fc_pp_scope : Error< - "'#pragma float_control push/pop' can only appear at file scope">; + "'#pragma float_control push/pop' can only appear at file scope or namespace scope">; def err_pragma_fc_noprecise_requires_nofenv : Error< "'#pragma float_control(precise, off)' is illegal when fenv_access is enabled">; def err_pragma_fc_except_requires_precise : Error< diff --git a/clang/lib/Sema/SemaAttr.cpp b/clang/lib/Sema/SemaAttr.cpp --- a/clang/lib/Sema/SemaAttr.cpp +++ b/clang/lib/Sema/SemaAttr.cpp @@ -413,8 +413,8 @@ auto NewValue = FpPragmaStack.CurrentValue; FPOptions NewFPFeatures(NewValue); if ((Action == PSK_Push_Set || Action == PSK_Push || Action == PSK_Pop) && - !CurContext->isTranslationUnit()) { - // Push and pop can only occur at file scope. + !(CurContext->isTranslationUnit()) && !CurContext->isNamespace()) { + // Push and pop can only occur at file or namespace scope. Diag(Loc, diag::err_pragma_fc_pp_scope); return; } diff --git a/clang/test/CodeGen/fp-floatcontrol-pragma.cpp b/clang/test/CodeGen/fp-floatcontrol-pragma.cpp --- a/clang/test/CodeGen/fp-floatcontrol-pragma.cpp +++ b/clang/test/CodeGen/fp-floatcontrol-pragma.cpp @@ -1,3 +1,4 @@ +// RUN: %clang_cc1 -DEXCEPT=1 -fcxx-exceptions -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-NS %s // RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s // RUN: %clang_cc1 -verify -DFENV_ON=1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s @@ -59,3 +60,38 @@ z = z * z; //CHECK: = fmul float } + +#if EXCEPT +namespace ns { +// Check that pragma float_control can appear in namespace. +#pragma float_control(except, on, push) +float exc_on(double x, float zero) { +// CHECK-NS: define {{.*}}exc_on{{.*}} + {} try { + x = 1.0 / zero; /* division by zero, the result unused */ +//CHECK-NS: llvm.experimental.constrained.fdiv{{.*}} + } catch (...) {} + return zero; +} +} + +// Check pragma is still effective after namespace closes +float exc_still_on(double x, float zero) { +// CHECK-NS: define {{.*}}exc_still_on{{.*}} + {} try { + x = 1.0 / zero; /* division by zero, the result unused */ +//CHECK-NS: llvm.experimental.constrained.fdiv{{.*}} + } catch (...) {} + return zero; +} + +#pragma float_control(pop) +float exc_off(double x, float zero) { +// CHECK-NS: define {{.*}}exc_off{{.*}} + {} try { + x = 1.0 / zero; /* division by zero, the result unused */ +//CHECK-NS: fdiv contract double + } catch (...) {} + return zero; +} +#endif // EXCEPT diff --git a/clang/test/Parser/fp-floatcontrol-syntax.cpp b/clang/test/Parser/fp-floatcontrol-syntax.cpp --- a/clang/test/Parser/fp-floatcontrol-syntax.cpp +++ b/clang/test/Parser/fp-floatcontrol-syntax.cpp @@ -10,10 +10,10 @@ #pragma float_control(pop) #pragma float_control(precise, on, push) void check_stack() { -#pragma float_control(push) // expected-error {{can only appear at file scope}} -#pragma float_control(pop) // expected-error {{can only appear at file scope}} -#pragma float_control(precise, on, push) // expected-error {{can only appear at file scope}} -#pragma float_control(except, on, push) // expected-error {{can only appear at file scope}} +#pragma float_control(push) // expected-error {{can only appear at file scope or namespace scope}} +#pragma float_control(pop) // expected-error {{can only appear at file scope or namespace scope}} +#pragma float_control(precise, on, push) // expected-error {{can only appear at file scope or namespace scope}} +#pragma float_control(except, on, push) // expected-error {{can only appear at file scope or namespace scope}} #pragma float_control(except, on, push, junk) // expected-error {{float_control is malformed}} return; }