Page MenuHomePhabricator

Add 'cmake' keyword argument to PollyBuilder and AOSPBuilder
AbandonedPublic

Authored by kparzysz on Apr 20 2020, 1:18 PM.

Details

Summary

This follows what ClangBuilder does (getClangCMakeBuildFactory).

Use it to set cmake to 3.17.0 on all hexagon builders.

Diff Detail

Event Timeline

kparzysz created this revision.Apr 20 2020, 1:18 PM
ldionne accepted this revision.Apr 20 2020, 1:39 PM
This revision is now accepted and ready to land.Apr 20 2020, 1:39 PM
kparzysz closed this revision.Apr 20 2020, 2:24 PM

Committed in 312225d90d437cff01577bc3e3e1851059691157 (forgot to add the review URL to the commit message).

gkistanova reopened this revision.Apr 20 2020, 9:41 PM

Hello Krzysztof,

Could you elaborate why do you need to parametrize the cmake command, please?
Do you plan running multiple versions of cmake on the same buildbot simultaniously?

Why just updating cmake on your bots is not anough and zorg changes are required?

This revision is now accepted and ready to land.Apr 20 2020, 9:41 PM

This is because the latest cmake was installed by hand in a non-standard location. There are no Ubuntu packages with the new cmake available for the version running on the bots (15.04).

Also, the clang factory did already accept cmake command as an argument, I thought that adding this to the other factories would make things consistent.

Any problems with making that new cmake be executed by default? Like adding it to the PATH or by using alternatives. This is something specific to that computer configuration, not to the build configuration.

Also, the clang factory did already accept cmake command as an argument,

That’s a legacy and was introduced for different purposes. It is just waiting for the next round of refactoring to be removed.

I changed it to using PATH.

Thank you very much, Krzysztof!

kparzysz abandoned this revision.Apr 22 2020, 6:38 AM

This change was reverted and replaced with another commit.