diff --git a/llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h b/llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h --- a/llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h +++ b/llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h @@ -20,18 +20,18 @@ #ifndef LLVM_ANALYSIS_INSTRUCTIONPRECEDENCETRACKING_H #define LLVM_ANALYSIS_INSTRUCTIONPRECEDENCETRACKING_H -#include "llvm/IR/Dominators.h" -#include "llvm/Analysis/OrderedInstructions.h" +#include "llvm/ADT/DenseMap.h" namespace llvm { +class BasicBlock; +class Instruction; + class InstructionPrecedenceTracking { // Maps a block to the topmost special instruction in it. If the value is // nullptr, it means that it is known that this block does not contain any // special instructions. DenseMap FirstSpecialInsts; - // Allows to answer queries about precedence of instructions within one block. - OrderedInstructions OI; // Fills information about the given block's special instructions. void fill(const BasicBlock *BB); @@ -49,9 +49,6 @@ #endif protected: - InstructionPrecedenceTracking(DominatorTree *DT) - : OI(OrderedInstructions(DT)) {} - /// Returns the topmost special instruction from the block \p BB. Returns /// nullptr if there is no special instructions in the block. const Instruction *getFirstSpecialInstruction(const BasicBlock *BB); @@ -96,9 +93,6 @@ /// perform PRE moving non-speculable instruction to other place. class ImplicitControlFlowTracking : public InstructionPrecedenceTracking { public: - ImplicitControlFlowTracking(DominatorTree *DT) - : InstructionPrecedenceTracking(DT) {} - /// Returns the topmost instruction with implicit control flow from the given /// basic block. Returns nullptr if there is no such instructions in the block. const Instruction *getFirstICFI(const BasicBlock *BB) { @@ -121,8 +115,6 @@ class MemoryWriteTracking : public InstructionPrecedenceTracking { public: - MemoryWriteTracking(DominatorTree *DT) : InstructionPrecedenceTracking(DT) {} - /// Returns the topmost instruction that may write memory from the given /// basic block. Returns nullptr if there is no such instructions in the block. const Instruction *getFirstMemoryWrite(const BasicBlock *BB) { diff --git a/llvm/include/llvm/Analysis/MustExecute.h b/llvm/include/llvm/Analysis/MustExecute.h --- a/llvm/include/llvm/Analysis/MustExecute.h +++ b/llvm/include/llvm/Analysis/MustExecute.h @@ -122,8 +122,6 @@ const DominatorTree *DT, const Loop *CurLoop) const; - SimpleLoopSafetyInfo() : LoopSafetyInfo() {}; - virtual ~SimpleLoopSafetyInfo() {}; }; @@ -171,8 +169,6 @@ /// this removal. void removeInstruction(const Instruction *Inst); - ICFLoopSafetyInfo(DominatorTree *DT) : LoopSafetyInfo(), ICF(DT), MW(DT) {}; - virtual ~ICFLoopSafetyInfo() {}; }; diff --git a/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp b/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp --- a/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp +++ b/llvm/lib/Analysis/InstructionPrecedenceTracking.cpp @@ -59,7 +59,7 @@ const Instruction *Insn) { const Instruction *MaybeFirstSpecial = getFirstSpecialInstruction(Insn->getParent()); - return MaybeFirstSpecial && OI.dominates(MaybeFirstSpecial, Insn); + return MaybeFirstSpecial && MaybeFirstSpecial->comesBefore(Insn); } void InstructionPrecedenceTracking::fill(const BasicBlock *BB) { diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -2145,7 +2145,7 @@ TLI = &RunTLI; VN.setAliasAnalysis(&RunAA); MD = RunMD; - ImplicitControlFlowTracking ImplicitCFT(DT); + ImplicitControlFlowTracking ImplicitCFT; ICF = &ImplicitCFT; this->LI = LI; VN.setMemDep(MD); diff --git a/llvm/lib/Transforms/Scalar/LICM.cpp b/llvm/lib/Transforms/Scalar/LICM.cpp --- a/llvm/lib/Transforms/Scalar/LICM.cpp +++ b/llvm/lib/Transforms/Scalar/LICM.cpp @@ -331,7 +331,7 @@ BasicBlock *Preheader = L->getLoopPreheader(); // Compute loop safety information. - ICFLoopSafetyInfo SafetyInfo(DT); + ICFLoopSafetyInfo SafetyInfo; SafetyInfo.computeLoopSafetyInfo(L); // We want to visit all of the instructions in this loop... that are not parts