diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -11847,10 +11847,18 @@ // be deduced based on the chosen correction if the original init contains a // TypoExpr. ExprResult Res = CorrectDelayedTyposInExpr(Init, VDecl); - if (!Res.isUsable() || Res.get()->containsErrors()) { + if (!Res.isUsable()) { + // There are unresolved typos in Init, just drop them. + // FIXME: improve the recovery strategy to preserve the Init. RealDecl->setInvalidDecl(); return; } + if (Res.get()->containsErrors()) { + // Invalidate the decl as we don't know the type for recovery-expr yet. + RealDecl->setInvalidDecl(); + VDecl->setInit(Res.get()); + return; + } Init = Res.get(); if (DeduceVariableDeclarationType(VDecl, DirectInit, Init)) diff --git a/clang/test/AST/ast-dump-expr-errors.cpp b/clang/test/AST/ast-dump-expr-errors.cpp --- a/clang/test/AST/ast-dump-expr-errors.cpp +++ b/clang/test/AST/ast-dump-expr-errors.cpp @@ -40,10 +40,6 @@ // CHECK-NEXT:| `-IntegerLiteral {{.*}} 1 int d = static_cast(bar() + 1); -// FIXME: store initializer even when 'auto' could not be deduced. -// Expressions with errors currently do not keep initializers around. -// CHECK: -VarDecl {{.*}} invalid e 'auto' -auto e = bar(); // Error type should result in an invalid decl. // CHECK: -VarDecl {{.*}} invalid f 'decltype((bar))' diff --git a/clang/test/AST/ast-dump-recovery.cpp b/clang/test/AST/ast-dump-recovery.cpp --- a/clang/test/AST/ast-dump-recovery.cpp +++ b/clang/test/AST/ast-dump-recovery.cpp @@ -156,3 +156,22 @@ // CHECK-NEXT: `-UnresolvedLookupExpr {{.*}} 'invalid' Bar b6 = Bar{invalid()}; } +void InitializerForAuto() { + // CHECK: `-VarDecl {{.*}} invalid a 'auto' + // CHECK-NEXT: `-RecoveryExpr {{.*}} '' contains-errors + // CHECK-NEXT: `-UnresolvedLookupExpr {{.*}} 'invalid' + auto a = invalid(); + + // CHECK: `-VarDecl {{.*}} invalid b 'auto' + // CHECK-NEXT: `-CallExpr {{.*}} '' contains-errors + // CHECK-NEXT: |-UnresolvedLookupExpr {{.*}} 'some_func' + // CHECK-NEXT: `-RecoveryExpr {{.*}} '' contains-errors + // CHECK-NEXT: `-UnresolvedLookupExpr {{.*}} 'invalid' + auto b = some_func(invalid()); + + decltype(ned); + // very bad initailizer: there is an unresolved typo expr internally, we just + // drop it. + // CHECK: `-VarDecl {{.*}} invalid unresolved_typo 'auto' + auto unresolved_typo = gned.*[] {}; +}